-
Notifications
You must be signed in to change notification settings - Fork 43
Collectibles Grid in wallet extension #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@marcelines is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would it take to have a single ui block for this whole view and have it rendered in both places with framework/routing dependencies passed as props?
apps/wallet/src/routes/portfolio/collectibles/index.tsx
apps/portfolio/src/app/[address]/@list/collectibles/page.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have that UI block for the grid, which is almost everything. We only have a wrapper in each place to pass those needed dependencies as props. Or do you mean a different thing?
Are |
Changes