Skip to content

Collectibles Grid in wallet extension #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

marcelines
Copy link
Collaborator

Changes

  • Adds collectible grid component to extension
  • Api collectibles router in extension

Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: d14fd25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 19, 2025

@marcelines is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@marcelines marcelines self-assigned this May 19, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would it take to have a single ui block for this whole view and have it rendered in both places with framework/routing dependencies passed as props?

  • apps/wallet/src/routes/portfolio/collectibles/index.tsx
  • apps/portfolio/src/app/[address]/@list/collectibles/page.tsx

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have that UI block for the grid, which is almost everything. We only have a wrapper in each place to pass those needed dependencies as props. Or do you mean a different thing?

@felicio
Copy link
Collaborator

felicio commented May 27, 2025

Are apps/portfolio routes still working for you?

@status-im-auto
Copy link
Member

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d14fd25 #1 2025-06-04 13:33:13 ~53 sec wallet 📦zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚧 In Progress
Development

Successfully merging this pull request may close these issues.

3 participants