-
Notifications
You must be signed in to change notification settings - Fork 43
Implement activity #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement activity #703
Conversation
|
@jinhojang6 is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
Jenkins BuildsClick to see older builds (3)
|
![]() Fixed the bug with from/to address : ce6dd8d We can now filter the transaction history by address |
Supports all networks: 8913980 const networks = searchParams.get('networks')?.split(',') ?? [
'ethereum',
'optimism',
'arbitrum',
'base',
'polygon',
'bsc',
] Some networks don't support the const unsupportedCategoriesByNetwork: Partial<Record<NetworkType, string[]>> = {
bsc: ['internal'],
arbitrum: ['internal'],
base: ['internal'],
optimism: ['internal'],
}
...
const supportedCategories = allCategories.filter(
category => !unsupportedCategoriesByNetwork[network]?.includes(category),
)
...
const body = await _retry(async () =>
_fetch<TokenBalanceHistoryResponseBody>(url, 'POST', 3600, {
jsonrpc: '2.0',
method: 'alchemy_getAssetTransfers',
params: [
{
category: supportedCategories, |
Alchemy redirects I didn’t change any other comments outside the scope of my work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One step closer again, so thank you!
Could we
- remove the
toAddress
limiting param - rebase on Detail pages routes #670 from As a user, I can see my sent transaction history #676 (comment) to test filtering interactively
- provide examples links of all supported transaction types, each shown in detail on the right side like then rebased base would for assets and collectibles routes
?
a918107
to
7bfb13e
Compare
@felicio I did
But didn't fully understand what you mean. I am testing at
|
@jinhojang6 thanks!
In other words, how can we verify that all the transactions types from #676 (comment) are supported? For example, |
We can classify the transfer by using the and can filter specific tokens by using the I verified that the eth(internal + external), erc 20, erc 721, and erc 1155 all work with the contract address filtering. Do you mean the team wants separate pages like the following?
|
How should those reviewing this verify that as well 🙂 ? |
@felicio You can replace
and add
|
Working on the issue: #676 (comment)
URL:
/page.html#/activity
chrome-extension://dbdopckibnkbapjohebcpomaeihajmfm/page.html#/activity
Using
getAssetTransfers
withoutfromAddress
andtoAddress
:Limitations
The
fromAddress
/toAddress
fields are not working yet.Currently deactivated them : https://github.com/status-im/status-web/pull/703/files#diff-912df96701a30d1254ed13d474cec37142ac015d5785a5517dc23b3d00434207R358-R359
Currently using Ethereum only : https://github.com/status-im/status-web/pull/703/files#diff-7772699e7ca99c68edc57f7f752c4ad62e265c070af0a5739a75b4f5ac2b8672R62-R67