Skip to content

feat: password validation (no UI) #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

yqrashawn
Copy link

@yqrashawn yqrashawn commented Jun 16, 2025

this PR is based on PR #704, please merge #704 before this one

resolve the none UI part of #698

Note

  • password validation requires password and walletId, which means this can't be used for unlocking the wallet if walletId is encrypted as well

Todo

  • when there's both walletId and password, validate the pwd and add a validPassword to ctx if password is valid (using keystore export for validation)
  • check validPassword before using it with keystore in other procedures

Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: ba88ad5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@status-im/trpc-webext Patch
wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 16, 2025

@yqrashawn is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@status-im-auto
Copy link
Member

status-im-auto commented Jun 16, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3755616 #1 2025-06-16 02:18:15 ~51 sec wallet 📦zip
✔️ ba88ad5 #2 2025-06-17 01:45:53 ~53 sec wallet 📦zip

@yqrashawn yqrashawn force-pushed the feat/password-auth branch from 3755616 to ba88ad5 Compare June 17, 2025 01:44
@yqrashawn yqrashawn changed the title feat: password auth [WIP] feat: password validation (no UI) Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚧 In Progress
Development

Successfully merging this pull request may close these issues.

2 participants