Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev tools #197

Merged
merged 15 commits into from
Nov 8, 2023
Merged

Update dev tools #197

merged 15 commits into from
Nov 8, 2023

Conversation

staylor
Copy link
Owner

@staylor staylor commented Oct 30, 2023 •
edited
Loading

This project has outdated deps and needs to properly render in React 18 mode during dev/test.

  • favor TypeScript over Babel
  • use Vitest over Jest
  • use React Testing Library over Enzyme
  • update CircleCI to use Node 18
  • use Remix ESLint config instead of kyt (from when I was at the New York Times)
  • wrap all test renders in <StrictMode>

@staylor
remove Babel and Enzyme
f4c27ff 
use esbuild to compile
use strict render for all
add renderContext helper
clean up types
@staylor staylor marked this pull request as ready for review November 7, 2023 17:04
@staylor staylor merged commit 6435fc0 into main Nov 8, 2023
This was referenced Nov 20, 2023
Closed
Closed
Closed
@laug laug mentioned this pull request Nov 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@staylor