Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/gamma-lanczos-g #6096

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

Neerajpathak07
Copy link
Contributor

@Neerajpathak07 Neerajpathak07 commented Mar 16, 2025

Progresses #649,
Resolves #6097.

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/gamma-lanczos-g

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 16, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float32/gamma-lanczos-g $\color{green}52/52$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}52/52$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 16, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review March 16, 2025 12:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 16, 2025
@Neerajpathak07
Copy link
Contributor Author

cc:- @kgryte Will be needing this to implement gamma-lanczos-sumf

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 18, 2025
@Neerajpathak07 Neerajpathak07 requested a review from kgryte March 18, 2025 09:49
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, the actual value of g in single-precision functions may not exactly correspond to the double-precision implementation. As such, this constant may need to be revisited. Previously, we first implemented the approximations and once implemented backed out the constants and common utilities. Creating the constant first puts this in reverse, which may not be warranted.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 18, 2025
@kgryte kgryte merged commit 04f0f1e into stdlib-js:develop Mar 18, 2025
13 checks passed
@Neerajpathak07
Copy link
Contributor Author

@kgryte Oh I see I'll look into it again as well.

@Neerajpathak07 Neerajpathak07 deleted the float32-gamma-lanczos-g branch March 18, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add constants/float32/gamma-lanczos-g
3 participants