-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add constants/float32/gamma-lanczos-g
#6096
feat: add constants/float32/gamma-lanczos-g
#6096
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
/stdlib update-copyright-years |
cc:- @kgryte Will be needing this to implement |
...@stdlib/constants/float32/gamma-lanczos-g/include/stdlib/constants/float32/gamma_lanczos_g.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, the actual value of g
in single-precision functions may not exactly correspond to the double-precision implementation. As such, this constant may need to be revisited. Previously, we first implemented the approximations and once implemented backed out the constants and common utilities. Creating the constant first puts this in reverse, which may not be warranted.
@kgryte Oh I see I'll look into it again as well. |
Progresses #649,
Resolves #6097.
Description
This pull request:
constants/float32/gamma-lanczos-g
Related Issues
This pull request:
constants/float32/gamma-lanczos-g
#6097Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers