Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/stats incr nanmpcorr #6141

Closed
wants to merge 3 commits into from
Closed

Feat/stats incr nanmpcorr #6141

wants to merge 3 commits into from

Conversation

hans2001
Copy link

Resolves #5600 .

Description

What is the purpose of this pull request?
Adds the @stdlib/stats/incr/nanmpcorr package to incrementally compute a moving sample Pearson correlation coefficient using a sliding window that propagates NaN values as specified by the mpcorr tests.

This pull request:

  • Adds the @stdlib/stats/incr/nanmpcorr package to incrementally compute a moving sample Pearson correlation coefficient using a sliding window that propagates NaN values as specified by the mpcorr tests.

test coverage:
Screenshot 2025-03-17 at 11 20 35 PM

example:
Screenshot 2025-03-17 at 11 20 05 PM

benchmark:
Screenshot 2025-03-17 at 11 18 57 PM

code coverage:
Screenshot 2025-03-17 at 11 23 52 PM

Related Issues

Does this pull request have any related issues?

No.

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

hans2001 added 3 commits March 17, 2025 21:57
@hans2001
feat(stats): add nanmpcorr package
0561d70 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@hans2001
fix(stats): syntax error
594c5af 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@hans2001
fix(stats): update benchmarks
f91104f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 18, 2025
stdlib-bot
stdlib-bot reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmpcorr $\color{green}171/171$
$\color{green}+100.00\%$ 		$\color{green}15/15$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}171/171$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@hans2001 hans2001 mentioned this pull request Mar 18, 2025
Open
3 tasks
@coehemang
Copy link

bro the feat title is wrong. You have not done nanpcorrdist

@hans2001 hans2001 changed the title Feat/stats incr nanpcorrdist Feat/stats incr nanmpcorr Mar 18, 2025
@hans2001 hans2001 closed this Mar 18, 2025
@hans2001 hans2001 deleted the feat/stats_incr_nanpcorrdist branch March 18, 2025 14:28
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 18, 2025
@hans2001 hans2001 restored the feat/stats_incr_nanpcorrdist branch March 18, 2025 14:52
@hans2001 hans2001 deleted the feat/stats_incr_nanpcorrdist branch March 18, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmpcorr
3 participants
@hans2001 @stdlib-bot @coehemang