Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint debug/macros #6152

Closed
wants to merge 2 commits into from
Closed

Conversation

Adithya-jh
Copy link

Resolves #6105

Description

What is the purpose of this pull request?

This pull request:

  • resolves the lining issues by updating the macros file.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 18, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/assign 4632 / 10439
+ 44.37 %
44 / 44
+ 100.00 %
0 / 43
+ 0.00 %
4632 / 10439
+ 44.37 %
stats/incr/nanmae 144 / 144
+ 100.00 %
8 / 8
+ 100.00 %
2 / 2
+ 100.00 %
144 / 144
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@Adithya-jh
Copy link
Author

@stdlib-bot review my code and tell me the updates.

@kgryte
Copy link
Member

kgryte commented Mar 19, 2025

@Adithya-jh Unfortunately, your PR contains unrelated changes. You seemed to have branched off whatever branch you added stats/incr/nanmae. You should have branched off of develop. See #5753 for a guide to using Git.

As such, I'll go ahead and close this PR, and I suggest opening a separate PR which only includes the changes for addressing the lint issues.

@kgryte kgryte added autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. and removed Needs Review A pull request which needs code review. labels Mar 19, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution due to Git history issues.

Some common issues include:

  • Merge conflicts
  • Inappropriate commit messages
  • Unrelated commits
  • Including changes from merged branches that weren't intended for this PR

We recommend opening a new pull request with only the intended changes.

Thank you for your interest in stdlib, and we look forward to your future contributions.

@stdlib-bot stdlib-bot closed this Mar 19, 2025
@Adithya-jh
Copy link
Author

Hi @kgryte, thanks for the review. My apologies—I mistakenly bundled another PR along with it. Please refer to PR #6219, which only includes the changes for the lint errors.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. First-time Contributor A pull request from a contributor who has never previously committed to the project repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants