Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6132 #6153

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

JavaTypedScript
Copy link

@JavaTypedScript JavaTypedScript commented Mar 18, 2025

Resolves #6132 .

Description

What is the purpose of this pull request?

This pull request:

  • This pull request resolves the c errors.

Related Issues

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: JavaTypedScript <[email protected]>
Signed-off-by: JavaTypedScript <[email protected]>
Signed-off-by: JavaTypedScript <[email protected]>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 18, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/smeanors $\color{green}373/373$
$\color{green}+100.00\%$
$\color{green}24/24$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}373/373$
$\color{green}+100.00\%$
strided/base/dmskmap $\color{green}224/224$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}224/224$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@anxhukumar
Copy link
Contributor

@JavaTypedScript You have opened your PR with the develop branch. Create a local branch and push your changes from there.

https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md

@JavaTypedScript
Copy link
Author

@JavaTypedScript You have opened your PR with the develop branch. Create a local branch and push your changes from there.

https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md

Thank you for mentioning that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants