-
-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add FAQ for linting errors #6157
base: develop
Are you sure you want to change the base?
docs: add FAQ for linting errors #6157
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
@aayush0325, please check this FAQ. Also I think we should have a FAQ for max length in javascript files too. What is your opinion? |
Signed-off-by: Shabareesh Shetty <[email protected]>
@aayush0325, I have added reference links as well as a FAQ for max length of javascript. Also I have removed a TODO in line 68 because I thought it was outdated. Please check if I am right. |
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above comments still need to be resolved first.
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
@anandkaranubc, I think I have solved all your comments, sorry for not noticing the comments |
Signed-off-by: Karan Anand <[email protected]>
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
type: pre_push_report
description: Results of running various checks prior to pushing changes. report:
none
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers