Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats/base/sstdevyc): add accessor protocol support #6159

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Jeevansm25
Copy link

Added accessor protocol support with accessors.js, updated ndarray.js to delegate, and added tests per RFC.
Resolves #5686

Description

This pull request:

  • Adds accessor protocol support with a new accessors.js file.
  • Updates ndarray.js to delegate to accessors.js for accessor arrays.
  • Modifies tests in test.ndarray.js to include accessor array cases.
  • Updates index.js to reflect changes.

Related Issues

Checklist

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers
[contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 18, 2025
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/sstdevyc $\color{red}445/457$
$\color{green}+97.37\%$
$\color{red}34/41$
$\color{green}+82.93\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{red}445/457$
$\color{green}+97.37\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/stdevyc
2 participants