Skip to content

feat: add missing tests to ndarray/base/every-by #7285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions lib/node_modules/@stdlib/ndarray/base/every-by/test/test.0d.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,10 @@
// MODULES //

var tape = require( 'tape' );
var Float64Array = require( '@stdlib/array/float64' );
var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
var Complex128 = require( '@stdlib/complex/float64/ctor' );
var real = require( '@stdlib/complex/float64/real' );
var imag = require( '@stdlib/complex/float64/imag' );
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
var ndarray = require( '@stdlib/ndarray/ctor' );
var everyBy = require( './../lib' );


Expand Down Expand Up @@ -68,27 +65,6 @@ tape( 'the function tests whether every element in a 0-dimensional ndarray passe
var actual;
var x;

x = ndarray( 'generic', toAccessorArray( new Float64Array( [ 0.0 ] ) ), [], [ 0 ], 0, 'row-major' );

actual = everyBy( [ x ], clbk );
t.strictEqual( actual, false, 'returns expected value' );

x = ndarray( 'generic', toAccessorArray( new Float64Array( [ 1.0 ] ) ), [], [ 0 ], 0, 'row-major' );

actual = everyBy( [ x ], clbk );
t.strictEqual( actual, true, 'returns expected value' );

t.end();

function clbk( v ) {
return v !== 0.0;
}
});

tape( 'the function tests whether every element in a 0-dimensional ndarray passes a test implemented by a predicate function (complex)', function test( t ) {
var actual;
var x;

x = scalar2ndarray( new Complex128( 0.0, 0.0 ), {
'dtype': 'complex128'
});
Expand Down
84 changes: 84 additions & 0 deletions lib/node_modules/@stdlib/ndarray/base/every-by/test/test.1d.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
/**
* @license Apache-2.0
*
* Copyright (c) 2025 The Stdlib Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

'use strict';

// MODULES //

var tape = require( 'tape' );
var ones = require( '@stdlib/array/ones' );
var zeros = require( '@stdlib/array/zeros' );
var real = require( '@stdlib/complex/float64/real' );
var imag = require( '@stdlib/complex/float64/imag' );
var Complex128Array = require( '@stdlib/array/complex128' );
var ndarray = require( '@stdlib/ndarray/ctor' );
var everyBy = require( './../lib' );


// TESTS //

tape( 'main export is a function', function test( t ) {
t.ok( true, __filename );
t.strictEqual( typeof everyBy, 'function', 'main export is a function');
t.end();
});

tape( 'the function tests whether every element in a 1-dimensional ndarray passes a test implemented by a predicate function', function test( t ) {
var actual;
var x;

x = ndarray( 'float64', zeros( 8, 'float64' ), [ 4 ], [ 2 ], 1, 'row-major' );

actual = everyBy( [ x ], clbk );
t.strictEqual( actual, false, 'returns expected value' );

x = ndarray( 'float64', ones( 8, 'float64' ), [ 4 ], [ 2 ], 1, 'row-major' );

actual = everyBy( [ x ], clbk );
t.strictEqual( actual, true, 'returns expected value' );

t.end();

function clbk( v ) {
return v !== 0;
}
});

tape( 'the function tests whether every element in a 1-dimensional ndarray passes a test implemented by a predicate function (accessors)', function test( t ) {
var actual;
var xbuf;
var x;

xbuf = zeros( 6*2, 'float64' );
x = ndarray( 'complex128', new Complex128Array( xbuf ), [ 4 ], [ 1 ], 1, 'row-major' );

actual = everyBy( [ x ], clbk );
t.strictEqual( actual, false, 'returns expected value' );

xbuf = ones( 6*2, 'float64' );
x = ndarray( 'complex128', new Complex128Array( xbuf ), [ 4 ], [ 1 ], 1, 'row-major' );

actual = everyBy( [ x ], clbk );
t.strictEqual( actual, true, 'returns expected value' );

t.end();

function clbk( v ) {
return ( real( v ) !== 0.0 && imag( v ) !== 0.0 );
}
});
Copy link
Member

@kgryte kgryte Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding four tests here, all of which should be testing that the function supports providing a callback execution context. I say four tests, as you want one for indexed arrays and another for accessor arrays in both row and column-major orders.

In those tests, you should cache provided callback arguments and test that provided arguments match expectation. In particular, that the sequence of values is correct, that the sequence of indices is correct, and that the array is provided on each call.

For reference, see also

tape( 'the function supports specifying the callback execution context (row-major)', function test( t ) {
where this sort of testing is performed.

Loading