Skip to content

Conversation

@SuYaSh-PaThAk04
Copy link
Contributor

Resolves #8294 .

Description

What is the purpose of this pull request?

This pull request:

  • fixes test failures in the @stdlib/array/base/fancy-slice module caused by recent updates introducing AccessorArray and consistent typed array outputs.

Specifically, it:

  • Updates test cases to expect AccessorArray and Float64Array outputs instead of plain JavaScript arrays ([]).
  • Ensures type and equality checks in tests correctly account for accessor-based arrays.
  • Aligns the behavior of empty slices and out-of-bounds slices with the updated implementation.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

image

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • [ x ] Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Added a self-import to satisfy linting rules.

Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Fix echo command in eslint-files target for linting.

Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 7, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
utils/async/parallel $\color{green}486/486$
$color{green}+100.00%$
$\color{green}44/44$
$color{green}+100.00%$
$\color{green}9/9$
$color{green}+100.00%$
$\color{green}486/486$
$color{green}+100.00%$
utils/async/while $\color{green}185/185$
$color{green}+100.00%$
$\color{green}22/22$
$color{green}+100.00%$
$\color{green}3/3$
$color{green}+100.00%$
$\color{green}185/185$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Good First PR A pull request resolving a Good First Issue. labels Nov 7, 2025
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants