feat: add `symbol/split` #8498

AdminAdi · 2025-11-10T18:28:04Z

Resolves #8488.

Description

What is the purpose of this pull request?

This pull request:

Adds new @stdlib/symbol/split package implementing Symbol.split support
Follows existing symbol package patterns (e.g., symbol/iterator, symbol/has-instance)
Includes comprehensive tests, benchmarks, and documentation
Exports Symbol.split when available, otherwise undefined

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: add symbol/split #8488

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

AI assistance was used for code structure guidance, test generation, and documentation formatting, but the implementation follows established stdlib patterns and was manually reviewed for consistency.

@stdlib-js/reviewers

stdlib-bot · 2025-11-10T18:28:14Z

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Please read our contributing guidelines if you haven't already.
For development guidance, refer to the development guide.

Next Steps

A project maintainer will approve GitHub Actions workflows for your PR.
All CI checks must pass before your submission can be fully reviewed.
You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

AdminAdi · 2025-11-17T06:24:39Z

See I have resolved the issue please merge the PR

kgryte · 2025-11-18T07:50:32Z

.github/workflows/run_tests_coverage.yml

        # Pin action to full length commit SHA
        uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
        with:
-          node-version: 20 # 'lts/*'


This change is not desired.

kgryte · 2025-11-18T07:50:54Z

lib/node_modules/@stdlib/symbol/split/README.md

+
+<section class="usage">
+
+## Usage


This file does not currently match project conventions.

kgryte · 2025-11-18T07:51:37Z

lib/node_modules/@stdlib/symbol/split/lib/browser.js

+* @see [MDN]{@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/split}
+* @default Symbol.split
+*/
+var SPLIT = ( typeof Symbol === 'function' && typeof Symbol.split === 'symbol' ) ? Symbol.split : '@@split'; // eslint-disable-line no-undef


Please see other packages exposing symbols. This is not how we implement them.

kgryte · 2025-11-18T07:51:46Z

lib/node_modules/@stdlib/symbol/split/main.js

+* @see [MDN]{@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/split}
+* @default Symbol.split
+*/
+var SPLIT = ( typeof Symbol === 'function' && typeof Symbol.split === 'symbol' ) ? Symbol.split : '@@split'; // eslint-disable-line no-undef


Same comment.

kgryte · 2025-11-18T07:52:22Z

lib/node_modules/@stdlib/symbol/split/package.json

+    "test": "make test",
+    "test-cov": "make test-cov",
+    "examples": "make examples"


These should not be here. It is not clear why you added these.

kgryte · 2025-11-18T07:52:30Z

lib/node_modules/@stdlib/symbol/split/package.json

+  },
+  "dependencies": {},
+  "devDependencies": {
+    "@stdlib/assert/has-symbol-support": "^0.0.0"


This should be removed.

kgryte · 2025-11-18T07:54:16Z

lib/node_modules/@stdlib/symbol/split/package.json

+    "linux",
+    "macos",
+    "openbsd",
+    "posix",


Suggested change

"posix",

Why was this added? This isn't an OS.

kgryte

Thank you for your interest; however, this PR does not follow project conventions. I suggest revisiting the original RFC and following its guidance.

stdlib-bot · 2025-12-27T01:05:16Z

Thank you for working on this pull request. However, we cannot accept your contribution as this pull request does not follow project conventions.

We place a high value on consistency throughout the stdlib codebase, and this pull request was found to significantly deviate from stdlib conventions. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.

If you are attempting to contribute a new package, sometimes the best approach is to simply copy the contents of an existing package and then modify the minimum amount necessary to implement the feature (e.g., changing descriptions, parameter names, and implementation).
If you are contributing tests, find a package implementing a similar feature and emulate the tests of that package.
If you are updating documentation, examine several similar packages and emulate the content, style, and prose of those packages.

In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before continuing to work on this pull request.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

Implemented Symbol.split package as per RFC requirements

bd378cf

stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 10, 2025

AdminAdi and others added 2 commits November 11, 2025 00:03

test

b070aa2

Merge branch 'stdlib-js:develop' into develop

e40ff60

stdlib-bot added Potential Duplicate There might be another pull request resolving the same issue. and removed Potential Duplicate There might be another pull request resolving the same issue. labels Nov 11, 2025

kgryte reviewed Nov 18, 2025

View reviewed changes

kgryte requested changes Nov 18, 2025

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 18, 2025

kgryte changed the title ~~Implemented Symbol.split package as per RFC requirements~~ feat: add symbol/split Nov 18, 2025

12adarshkumar12 mentioned this pull request Nov 19, 2025

feat: add symbol/split #8555

Open

7 tasks

stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Nov 20, 2025

kgryte added the autoclose: Project Conventions Pull request which should be auto-closed due to not following project conventions. label Dec 27, 2025

stdlib-bot closed this Dec 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `symbol/split` #8498

feat: add `symbol/split` #8498

Uh oh!

AdminAdi commented Nov 10, 2025

Uh oh!

stdlib-bot commented Nov 10, 2025

Uh oh!

AdminAdi commented Nov 17, 2025

Uh oh!

kgryte Nov 18, 2025

Uh oh!

kgryte Nov 18, 2025

Uh oh!

kgryte Nov 18, 2025

Uh oh!

kgryte Nov 18, 2025

Uh oh!

kgryte Nov 18, 2025

Uh oh!

kgryte Nov 18, 2025

Uh oh!

kgryte Nov 18, 2025

Uh oh!

kgryte left a comment

Uh oh!

stdlib-bot commented Dec 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat: add symbol/split #8498

feat: add symbol/split #8498

Uh oh!

Conversation

AdminAdi commented Nov 10, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Nov 10, 2025

Getting Started

Next Steps

Running Tests Locally

Documentation Links

Uh oh!

AdminAdi commented Nov 17, 2025

Uh oh!

kgryte Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Dec 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `symbol/split` #8498

feat: add `symbol/split` #8498