Skip to content

chore: fix JavaScript lint errors (issue #9527) #9530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 7 commits into from
Jan 5, 2026
Merged

chore: fix JavaScript lint errors (issue #9527) #9530

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e69bb12
chore: fix JavaScript lint errors (issue #9527)
kaushal-kumar-it Jan 4, 2026
28b37ee
style: disable lint rule
kgryte Jan 5, 2026
b607e01
Discard changes to lib/node_modules/@stdlib/assert/deep-has-own-prope…
kgryte Jan 5, 2026
0a40f58
style: address lint failure
kgryte Jan 5, 2026
c9fc892
style: resolve lint failure
kgryte Jan 5, 2026
185a990
style: address lint failure
kgryte Jan 5, 2026
2a8dfaf
style: resolve lint failure
kgryte Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/lapack/base/dlaswp/test/test.dlaswp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
var COL_MAJOR_IPIV_STRIDE_NEG = require( './fixtures/column_major_ipiv_stride_negative.json' );
var COL_MAJOR_LDA = require( './fixtures/column_major_lda.json' );
var COL_MAJOR_REV_PIVOTS = require( './fixtures/column_major_reverse_pivots.json' );
var COL_MAJOR_K1 = require( './fixtures/column_major_k1.json' );
var COL_MAJOR_K1 = require( './fixtures/column_major_k1.json' ); // eslint-lint-disable-next-line stdlib/no-empty-lines-between-requires
Copy link
Member

@kgryte kgryte Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter This is somewhat of an awkward disabling of a lint rule. The offending line is L45, so this is the only way to disable this lint rule. Better would be if the lint error targeted L46 because we could then do

// eslint-disable-line stdlib/no-empty-lines-between-requires

as that is where the offending require statement is.

Copy link
Member

@kgryte kgryte Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...this attempt to disable the lint rule didn't work. I need to figure out another workaround.

Copy link
Member

@kgryte kgryte Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up having to disable and then re-enable for the entire chunk of lines.

Copy link
Member

@kgryte kgryte Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even that worked.


Check failure on line 45 in lib/node_modules/@stdlib/lapack/base/dlaswp/test/test.dlaswp.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected empty line between require statements
var ROW_MAJOR = require( './fixtures/row_major_no_offsets.json' );
var ROW_MAJOR_IPIV_STRIDE_POS = require( './fixtures/row_major_ipiv_stride_positive.json' );
var ROW_MAJOR_IPIV_STRIDE_NEG = require( './fixtures/row_major_ipiv_stride_negative.json' );
Expand Down
1 change: 1 addition & 0 deletions lib/node_modules/@stdlib/utils/nonenumerable-property-names/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

var getOwnPropertyNames = require( '@stdlib/utils/property-names' );
var isNonEnumerableProperty = require( '@stdlib/assert/is-nonenumerable-property' );
var Object = require( '@stdlib/object/ctor' );


// MAIN //
Expand Down
Loading