Add DiscoveryKit features for Argo Rollout kinds. #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReuDa
requested changes
Aug 29, 2025
charts/steadybit-extension-kubernetes/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
| {{- end }} | ||
| - name: STEADYBIT_EXTENSION_DISCOVERY_MAX_POD_COUNT | ||
| value: "{{ .Values.discovery.maxPodCount }}" | ||
| {{- if .Values.discovery.disableArgoRollouts }} |
Member
There was a problem hiding this comment.
Could you add a test to charts/steadybit-extension-kubernetes/tests/deployment_test.yaml -> manifest should match snapshot with disabled discoveries
jay-hankins
force-pushed
the
add-argo-rollouts-discovery
branch
3 times, most recently
from
407744f to
8c3f4e0
Compare
jay-hankins
force-pushed
the
add-argo-rollouts-discovery
branch
from
caa5222 to
49c1bb0
Compare
jay-hankins
force-pushed
the
add-argo-rollouts-discovery
branch
from
49c1bb0 to
f38fc75
Compare
… add-argo-rollouts-discovery This brings in e2e test improvments from upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for discovering and monitoring changes to Argo Rollout resources in a cluster.
It adds an
argoRollouttype to the K8SClientwrapper:RolloutLister,RolloutNamespaceLister, making use ofcache.Indexerto support the major use cases, toList()and getRollouts().Clientto retrieve Rollouts.Note that we hand-rolled the types to avoid bringing in a dependency on
argoprojv1. This also means that we are using adynamicclient for Kubernetes, which uses typeunstructured.Unstructred{}to support any generic kind of CRD.We also add permissions:
_permissions.tplto get/list/watch aroproj.io rolloutspermissions.go, to mark the resource permission as required (with graceful failure)It adds
testutil/dynamic_client.goto support creating a dynamic test-double (adding Argo Rollout and RolloutList to the schema). Because the wrapper Client is now using both aclientset(static types) and a dynamicclient, the faked dynamic client is used by existing tests (e.g. container, daemonset, ..., etc.) even where they do not test Rollout functionality.