Retry installation hierarchy request on 204 No Content#36
Merged
Conversation
After granting access via OAuth, the Zaptec API occasionally returns a 204 before the authorization is fully processed. Retry once after 2 seconds, and raise RequestFailed if the second attempt also returns 204.
martijnversluis
force-pushed
the
retry-204-installation-hierarchy
branch
from
05d6987 to
aaa0a08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Na het verlenen van toegang via OAuth geeft de Zaptec API soms een 204 terug voordat de autorisatie volledig verwerkt is. Bij een refresh werkt het wel.
Fix: retry eenmalig na 2 seconden. Als de tweede poging ook een 204 geeft, raise
RequestFailed.