Remove SEP-24 secret from the reference server #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Do you plan to make another release to sync with the stg and testacnhor? |
JiahuiWho
approved these changes
Mar 6, 2025
lijamie98
reviewed
Mar 6, 2025
| @@ -25,9 +25,8 @@ spec: | |||
| { | |||
| "POSTGRES_USER": "postgres", | |||
| "POSTGRES_PASSWORD": "123456789", | |||
| "SEP6_SECRET": "SAJW2O2NH5QMMVWYAN352OEXS2RUY675A2HPK5HEG2FRR2NXPYA4OLYN", | |||
| "SECRET": "SAJW2O2NH5QMMVWYAN352OEXS2RUY675A2HPK5HEG2FRR2NXPYA4OLYN", | |||
There was a problem hiding this comment.
SECRET is too general. Can we rename the reference server's AppConfig::secret to something more meaningful since it is shared between SEPs.
ex: paymentSigningSecret, etc.
This isn't urgent and can go out in the next planned release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This combines the secret keys used by the reference server for payments.
Context
There's no need to have two separate accounts.
Testing
./gradlew testDocumentation
N/A
Known limitations
N/A