Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: add ToTransactionParams to Transaction #4334

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

txnbuild: add ToTransactionParams to Transaction #4334

wants to merge 8 commits into from

Conversation

MishraShivendra
Copy link
Contributor

#3649 Feature Request: txnbuild: add ability to create TransactionParams from Transaction

  • Generate TranscationParam out of a Transaction

2opremio
2opremio reviewed Apr 13, 2022
View reviewed changes
@2opremio
Copy link
Contributor

Minor comment, otherwise LGTM.

leighmcculloch
leighmcculloch reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things I think we need to address inline.

@MishraShivendra
Copy link
Contributor Author

MishraShivendra commented Apr 13, 2022 •
edited
Loading

Hi @2opremio @leighmcculloch , Thanks for taking a look into the changes. I have pushed those suggestions.
Please let me know if there is anything else needed.

@leighmcculloch leighmcculloch changed the title Convert transcation to transcationParam txnbuild: add ToTransactionParams to Transaction Apr 14, 2022
Shaptic
Shaptic requested changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, with the introduction of Protocol 19, this PR will need to be updated to take into account the new Preconditions field on transaction parameters.

@tsachiherman
Copy link
Contributor

@MishraShivendra could you please update this PR, or, in case you're no longer tracking this project, close it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch left review comments

@Shaptic Shaptic Awaiting requested review from Shaptic

@2opremio 2opremio Awaiting requested review from 2opremio

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MishraShivendra @2opremio @tsachiherman @leighmcculloch @Shaptic