5550/xdrill transactions #5579
Open
5550/xdrill transactions #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…550/xdrill-transactions
7 tasks
tamirms
reviewed
Jan 31, 2025
| // Fee charged = inclusion fee * (operation count + if(feeBumpAccount is not null, 1, 0)) | ||
| // or inclusionFee = feeCharged/(operation count + if(feeBumpAccount is not null, 1, 0)) | ||
| operationCount := t.OperationCount() | ||
| if t.Envelope.Type == 5 { // xdr.EnvelopeTypeEnvelopeTypeTxFeeBump |
There was a problem hiding this comment.
Suggested change
| if t.Envelope.Type == 5 { // xdr.EnvelopeTypeEnvelopeTypeTxFeeBump | |
| if t.Envelope.Type == xdr.EnvelopeTypeEnvelopeTypeTxFeeBump { |
Why not compare against xdr.EnvelopeTypeEnvelopeTypeTxFeeBump instead of 5 ?
tamirms
reviewed
Jan 31, 2025
Comment on lines
+197
to
+201
| sourceAccount := t.Envelope.SourceAccount() | ||
| providedID := sourceAccount.ToAccountId() | ||
| pointerToID := &providedID | ||
|
|
||
| return pointerToID.GetAddress() |
There was a problem hiding this comment.
Suggested change
| sourceAccount := t.Envelope.SourceAccount() | |
| providedID := sourceAccount.ToAccountId() | |
| pointerToID := &providedID | |
| return pointerToID.GetAddress() | |
| sourceAccount := t.Envelope.SourceAccount().ToAccountId() | |
| return sourceAccount.GetAddress() |
tamirms
reviewed
Jan 31, 2025
| func (t *LedgerTransaction) Memo() string { | ||
| memoObject := t.Envelope.Memo() | ||
| memoContents := "" | ||
| switch xdr.MemoType(memoObject.Type) { |
There was a problem hiding this comment.
I think you should handle all cases including MEMO_NONE and then you can add a default case which panics. That way if you forget to support a new memo case in the future the library can fail instead of mistakenly returning the empty string without errors
There was a problem hiding this comment.
this comment also applies to other switch cases in this file and other xdrill files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This is a copy of chowbao#1 where this PR merges into stellar/go
#5550
xdrill functions for Transactions
Why
Helper functions for Transactions for processors/transforms from stellar-etl for history_transactions found here
Known limitations