-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest/ledgerbackend: Add ledger backend which replays ledgers #5584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@karthikiyer56 I think I have addressed your code review feedback, could you take another look? |
karthikiyer56
approved these changes
Feb 3, 2025
2opremio
reviewed
Feb 3, 2025
2opremio
reviewed
Feb 3, 2025
2opremio
reviewed
Feb 3, 2025
2opremio
reviewed
Feb 3, 2025
2opremio
reviewed
Feb 3, 2025
2opremio
reviewed
Feb 3, 2025
All my comments are optional. I am mostly concerned about the role of the passed ledger backend, which is a bit unintuitive to me. |
2opremio
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
CHANGELOG.md
within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #5480
Following #5556 , this PR implements a ledger backend which takes synthetically generated ledgers, merges them with real ledgers, and then replays them at a configurable rate.
Why
This ledger backend will be used to benchmark ingestion duration for horizon / rpc when ingesting ledgers with a high volume of soroban transactions. These benchmarks will inform us of horizon and rpc's ceiling when it comes to ingestion throughput.
Known limitations
[N/A]