Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract Explorer: Contract spec #1251

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Contract Explorer: Contract spec #1251

wants to merge 10 commits into from
+351 −32

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented Feb 14, 2025 •
edited
Loading

  • Using @monaco-editor/react for code editor (React wrapper for Monaco Editor that is used in VS Code).
    • NOTE: I relaxed CSP rules for style-src to make styles work for the Monaco Editor. The files are pulled from a CDN. I couldn't figure out how to configure Next.js to use files locally.
  • Fetching wasm data using Stellar SDK from RPC.
  • Small refactoring to improve code reuse.

image

@quietbits quietbits marked this pull request as draft February 14, 2025 19:16
@socket-security Socket Security
Copy link

socket-security bot commented Feb 14, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@monaco-editor/[email protected] None 0 86.1 kB surenat
npm/@monaco-editor/[email protected] None 0 153 kB surenat
npm/[email protected] None 0 37.3 kB surenat

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Feb 14, 2025 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1251.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1251.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1251.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1251.previews.kube001.services.stellar-ops.com/

This was linked to issues Mar 4, 2025
Contract Details > Contract Spec #1198
Open
Fetch Wasm from the RPC #1248
Open
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1251.previews.kube001.services.stellar-ops.com/

@quietbits quietbits marked this pull request as ready for review March 4, 2025 20:00
@quietbits quietbits requested a review from jeesunikim March 4, 2025 20:10
@janewang
Copy link
Contributor

janewang commented Mar 5, 2025

Screenshot 2025-03-05 at 9 07 15 AM I got an axios error. See above.

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1251.previews.kube001.services.stellar-ops.com/

jeesunikim
jeesunikim approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@jeesunikim jeesunikim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeesunikim jeesunikim jeesunikim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Backlog (Not Ready)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch Wasm from the RPC Contract Details > Contract Spec
4 participants
@quietbits @stellar-jenkins @janewang @jeesunikim