Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade stellar-wallets-kit & enable ledger feature #1258

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jeesunikim
Copy link
Contributor

@jeesunikim jeesunikim commented Feb 20, 2025

Waiting on:

  • not a blocker: asked stellar-wallets-kit to enable onError handling for createButton (issue created); we could also create one manually and use openModal instead

Summary:

  • Added a Ledger option on signing
ledger-flow-01 ledger-flow-02 ledger-success-state ledger-error-state

Copy link

socket-security bot commented Feb 20, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@creit.tech/[email protected]1.6.1 None 0 529 kB earrietadev
npm/@emurgo/[email protected]11.5.0 eval 0 3.35 MB lisicky_emurgo
npm/@emurgo/[email protected]11.5.0 eval, filesystem 0 3.35 MB lisicky_emurgo
npm/@fivebinaries/[email protected]2.2.1 None 0 149 kB slowbackspace
npm/@hot-wallet/[email protected] network 0 142 kB hot-wallet
npm/@near-js/[email protected] None +2 273 kB nearndy
npm/@near-js/[email protected] None 0 62.1 kB nearndy
npm/@near-wallet-selector/[email protected] eval +1 496 kB trechriron
npm/@noble/[email protected] None +1 2.1 MB paulmillr
npm/@solana/[email protected] None 0 97.3 kB jordansexton
npm/@solana/[email protected] None +1 94.2 kB solana-devs
npm/@solana/[email protected] network +3 12.6 MB solana-devs
npm/@stellar/[email protected]4.0.0 None +1 180 kB stellar-npm-ci
npm/@trezor/[email protected]1.2.5 None +1 84.2 kB trezor-ci
npm/@trezor/[email protected]1.2.5 None 0 60 kB trezor-ci
npm/@trezor/[email protected]1.2.6 None 0 59.9 kB trezor-ci
npm/@trezor/[email protected]2.3.6 None +1 1.89 MB trezor-ci
npm/@trezor/[email protected]1.2.4 None 0 5.52 kB trezor-ci
npm/@trezor/[email protected]0.2.7 None 0 202 kB trezor-ci
npm/@trezor/[email protected]9.4.7 None +1 170 kB trezor-ci
npm/@trezor/[email protected]9.4.7 None +2 1.5 MB trezor-ci
npm/@trezor/[email protected]1.2.1 None 0 17.9 kB trezor-ci
npm/@trezor/[email protected]1.2.6 None 0 1.01 MB trezor-ci
npm/@trezor/[email protected]1.2.3 None 0 39.4 kB trezor-ci
npm/@trezor/[email protected]1.3.7 None 0 168 kB trezor-ci
npm/@trezor/[email protected]2.2.6 None 0 237 kB trezor-ci
npm/@types/[email protected]0.0.174 None 0 2.76 MB types
npm/@wallet-standard/[email protected] None 0 41.1 kB jordansexton
npm/[email protected] None 0 7.08 kB dcousens
npm/[email protected] None 0 80.1 kB boatnear
npm/[email protected] None 0 4.79 kB jprichardson
npm/[email protected] None 0 2.93 kB pvorb
npm/[email protected] None 0 5.03 kB pvorb
npm/[email protected] environment, eval 0 27.1 kB dougwilson
npm/[email protected] None 0 38 kB lpinca
npm/[email protected] None 0 39.5 kB emn178
npm/[email protected] None 0 6.72 kB styfle
npm/[email protected] None 0 110 kB flipp
npm/[email protected] None 0 380 kB nicknaso
npm/[email protected]4.8.4 None 0 13.9 kB mafintosh
npm/[email protected] None 0 2.14 MB fanatid
npm/[email protected] None 0 96.7 kB npm-cli-ops
npm/[email protected] None 0 7.68 kB pvorb
npm/[email protected] None 0 4.41 kB tracker1

🚮 Removed packages: npm/@scure/[email protected], npm/@scure/[email protected]

View full report↗︎

@stellar-jenkins
Copy link

2 similar comments
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@jeesunikim jeesunikim marked this pull request as ready for review March 5, 2025 20:57
@jeesunikim jeesunikim requested a review from quietbits March 5, 2025 21:00
@jeesunikim jeesunikim force-pushed the update-stellar-wallets-kit branch from c9eae7d to 68424a0 Compare March 6, 2025 01:30
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Deprecated npm/[email protected]
  • Reason: use 3.0.0 instead, safe-buffer has been merged and release for compatability
⚠︎

View full report↗︎

Next steps

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@stellar-jenkins
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog (Not Ready)
Development

Successfully merging this pull request may close these issues.

3 participants