Skip to content

[WIP] Win TS bindings test #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 68 commits into
base: main
Choose a base branch
from
Draft

[WIP] Win TS bindings test #1781

wants to merge 68 commits into from

Conversation

ifropc
Copy link
Contributor

@ifropc ifropc commented Dec 5, 2024

What

This was an attempt to run bindings tests on Windows, using quickstart docker image.
We were using WSL to run Docker and quickstart was running in this docker.
The container proved to be unstable

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@ifropc ifropc changed the title Run ts tests on win/mac Multiplatform TS bindings test Dec 5, 2024
@ifropc ifropc force-pushed the multiplatform-ts-bindings branch from b1cd77f to 7be111a Compare December 5, 2024 20:32
@ifropc ifropc force-pushed the multiplatform-ts-bindings branch 2 times, most recently from b0ad306 to cd40f88 Compare December 10, 2024 19:48
@ifropc ifropc force-pushed the multiplatform-ts-bindings branch from cd40f88 to e95f840 Compare December 10, 2024 19:49
@ifropc ifropc force-pushed the multiplatform-ts-bindings branch from 11ba697 to 1ec44df Compare February 26, 2025 01:02
@ifropc ifropc force-pushed the multiplatform-ts-bindings branch from cf254ef to a6bb221 Compare February 26, 2025 03:38
@ifropc ifropc force-pushed the multiplatform-ts-bindings branch from d75cee2 to 98d64f0 Compare February 26, 2025 04:23
@ifropc ifropc linked an issue Mar 10, 2025 that may be closed by this pull request
@ifropc ifropc force-pushed the multiplatform-ts-bindings branch from a876bc6 to 38c72a7 Compare March 18, 2025 22:15
@ifropc ifropc changed the title Multiplatform TS bindings test [WIP] Win TS bindings test Apr 11, 2025
@sagpatil sagpatil requested a review from Copilot May 5, 2025 20:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR investigates the instability of Windows bindings tests by reconfiguring the GitHub workflow files to run tests in a containerized environment.

  • Disabled pull_request triggers in some workflow files.
  • Introduces a strategy matrix for bindings tests with OS-specific configurations and setup steps.
  • Adds additional steps and conditions for WSL-based execution on Windows.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/rust.yml Comments out the pull_request trigger to limit the scope to push events.
.github/workflows/bindings-ts.yml Reworks the test job to use a matrix strategy with OS-specific setup including WSL installation and Docker configuration.
.github/workflows/binaries.yml Comments out the pull_request trigger; similar approach as in the rust workflow.
Comments suppressed due to low confidence (1)

.github/workflows/bindings-ts.yml:151

  • [nitpick] The step name 'quickstart logs' is reused for different OS conditions; consider using distinct names (e.g. 'quickstart logs (Linux)' and 'quickstart logs (Windows)') for better clarity in the workflow logs.
- name: quickstart logs

Comment on lines +123 to +131
Write-Host "Generating keys"
$env:SOROBAN_SECRET_KEY='SC5NRVW24PTAE2TM4M7VVZSCYUNVCBSZOSNRSHFU2XVYZGNMFV6YVLLX'
cargo run -p stellar-cli -- keys add --secret-key root
working-directory: cmd/crates/soroban-spec-typescript/ts-tests
- run: Invoke-RestMethod -Uri http://localhost:8000/friendbot?addr=GBGZY2GOHG7SDZTU6Y74T4EIZBL7XKW4MI6OJIQFMF4EUGAHUK5H7HKF
- run: |
Write-Host "Generating keys"
$env:SOROBAN_SECRET_KEY='SC5NRVW24PTAE2TM4M7VVZSCYUNVCBSZOSNRSHFU2XVYZGNMFV6YVLLX'
cargo run -p stellar-cli -- keys add --secret-key root
Copy link
Preview

Copilot AI May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] A similar key generation step appears to be repeated; consider consolidating these steps to reduce redundancy and simplify maintenance.

Suggested change
Write-Host "Generating keys"
$env:SOROBAN_SECRET_KEY='SC5NRVW24PTAE2TM4M7VVZSCYUNVCBSZOSNRSHFU2XVYZGNMFV6YVLLX'
cargo run -p stellar-cli -- keys add --secret-key root
working-directory: cmd/crates/soroban-spec-typescript/ts-tests
- run: Invoke-RestMethod -Uri http://localhost:8000/friendbot?addr=GBGZY2GOHG7SDZTU6Y74T4EIZBL7XKW4MI6OJIQFMF4EUGAHUK5H7HKF
- run: |
Write-Host "Generating keys"
$env:SOROBAN_SECRET_KEY='SC5NRVW24PTAE2TM4M7VVZSCYUNVCBSZOSNRSHFU2XVYZGNMFV6YVLLX'
cargo run -p stellar-cli -- keys add --secret-key root
- name: Generate keys
run: |
Write-Host "Generating keys"
$env:SOROBAN_SECRET_KEY='SC5NRVW24PTAE2TM4M7VVZSCYUNVCBSZOSNRSHFU2XVYZGNMFV6YVLLX'
cargo run -p stellar-cli -- keys add --secret-key root
shell: pwsh
working-directory: cmd/crates/soroban-spec-typescript/ts-tests
- run: Invoke-RestMethod -Uri http://localhost:8000/friendbot?addr=GBGZY2GOHG7SDZTU6Y74T4EIZBL7XKW4MI6OJIQFMF4EUGAHUK5H7HKF
- run: |
- name: Generate keys
uses: ./.github/workflows/bindings-ts.yml
with:
step: generate-keys

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog (Not Ready)
Development

Successfully merging this pull request may close these issues.

Enable TS bindings tests for Windows
2 participants