Pin rust version to exact version 1.74.1 #4131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
Pin the rust version using for building to exact the version 1.74.1.
Why
It appears that the stable releases of stellar-core have been built with Rust version 1.74.1.
According to @graydon in stellar/rs-soroban-env#1311 (comment) the intent is to pin stellar-core to a version of Rust.
At the moment it is pinned to a minor version of Rust, but new patch releases of Rust will cause rebuilds of stellar-core, or new builds of new commits, to automatically use the newer patch releases.
I think it's likely we'd want to use newer releases, but we should remain in control of when they are adopted and ideally builds of past source using the rust-toolchain.toml file to select a version are as consistent and reproducible as possible. i.e. They should use the same version of Rust they were originally built with. e.g. 1.74.1, not 1.74.n.
This change doesn't prevent us from changing the version on new Rust releases. It just makes sure we're the ones making the decision on when the change occurs.
Close stellar/rs-soroban-env#1311
Checklist
Ranclang-format
v8.0.0 (viamake format
or the Visual Studio extension)If change impacts performance, include supporting evidence per the performance document