Switch in-memory index to hash set #4665
Merged
+148
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested changes
Mar 21, 2025
marta-lokhova
previously approved these changes
Mar 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@SirTyson ah looks like this PR didn't merge due to some status check failures |
SirTyson
force-pushed
the
in-memory-bucket-optimization
branch
from
11edf7f to
3cd1714
Compare
marta-lokhova
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Significantly improve in-memory bucket performance.
This PR changes in-memory buckets from a vector to an unordered_set. This doubles median lookup speed, but more importantly removes all slow outliers seen with the vector approach (as tested on my laptop). To keep the minimum possible memory footprint, I've created a bit of a hacky set which stores an
implclass. Theimplcan either be a key type or a value type. The intention is the set only stores value type entries, but key type entries can be used for querying. C++20 introduces transparent hashes which accomplish the same goal, but in a much cleaner, more statically typesafe way, so we should refactor this once we upgrade.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)