Adapt Core to the CAP-67 XDR. #4666
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unfortunately rather hacky in order to allow for these changes to go in a minor release. Specifically, we're only bumping XDR for the Core itself, and not for the Rust env. That's why we need to temporarily disable a few XDR integrity checks. There is also a point of interaction of the new and old XDR(ScAddress changes), and I've added some tests to ensure that Core won't be able to accidentally accept XDR that's not supported by the current protocol.
jayz22
reviewed
Mar 13, 2025
| cpp.first.filename() == "Stellar-ledger.x") | ||
| { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
instead of skipping, would it be better to statically assert the hashes of these files, on both sides?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt Core to the CAP-67 XDR.
This is unfortunately rather hacky in order to allow for these changes to go in a minor release. Specifically, we're only bumping XDR for the Core itself, and not for the Rust env. That's why we need to temporarily disable a few XDR integrity checks. There is also a point of interaction of the new and old XDR(ScAddress changes), and I've added some tests to ensure that Core won't be able to accidentally accept XDR that's not supported by the current protocol.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)