Label info link + update Tooltip theme setting#242
Merged
Conversation
|
Preview is available here: |
|
Preview is available here: |
quietbits
commented
Apr 30, 2024
Comment on lines
+56
to
+64
| callback={(isOpen) => { | ||
| if (isOpen) { | ||
| const theme = document.body.getAttribute("data-sds-theme"); | ||
|
|
||
| if (theme) { | ||
| setTheme(theme); | ||
| } | ||
| } | ||
| }} |
Contributor
Author
There was a problem hiding this comment.
Using a callback is more accurate than using a listener.
quietbits
commented
Apr 30, 2024
| if (isDarkMode) { | ||
| document.body.classList.remove(ThemeMode.LIGHT); | ||
| document.body.classList.add(ThemeMode.DARK); | ||
| document.body.setAttribute("data-sds-theme", ThemeMode.DARK); |
Contributor
Author
There was a problem hiding this comment.
Other components can check for this attribute to get the current theme.
jeesunikim
approved these changes
Apr 30, 2024
quietbits
added a commit
that referenced
this pull request
Jan 23, 2025
* v3 colors (#206) * New color palette vars * Typography * V3 icons and logos (#207) * New color palette vars * Typography * V3 icons and logos * V3 Button (#209) * New color palette vars * Typography * V3 icons and logos * Button * Icon fixes * Badge (#210) * Notification (#211) * Banner (#212) * Banner * Adjust icon * Tooltip (#213) * Update CSS vars + Toggle + ThemeSwitch (#214) * Rename all vars with prefix --sds- * Updated color vars + Toggle + ThemeSwitch * Fix color * Fix more colors * SDS web: update colors (#215) * V3 Checkbox and Radio button updated (#216) * Checkbox updated * Radio button updated * V3 Textarea updated (#217) * Checkbox updated * Radio button updated * V3 Textarea updated * Fix disabled hover * V3 Asset, Avatar, and Profile (#218) * Asset updated * Avatar updated * Profile updated * V3 Alert + new variants for Link (#219) * Added new variants to Link component * Alert component * Cleanup * V3 Modal (#220) * Support custom anchor elements (#221) * Support custom anchor elements * Updated Profile and ProjectLogo * Bump SDS to v2.0.0-beta.1 * V3 Select (#222) * V3 Input (#223) * Bump SDS to v2.0.0-beta.1 * Fix Input copy action in form * Bump SDS to v2.0.0-beta.3 * Bump SDS to v2.0.0-beta.4 * Update Text component (#224) * Bump SDS to v2.0.0-beta.5 * Add Label suffix (#226) * Bump SDS to v2.0.0-beta.6 * Add lime and sky accent colors (#227) * Bump SDS to v2.0.0-beta.7 * V3 Updated Alert and Notification background color (#228) * Update Alert background color * Updated Notification background * Update anim transition duration * Bump SDS to v2.0.0-beta.8 * V3 Label: update color (#231) * V3 CopyText updated (#232) * V3 Update Modal (#234) * V3 Use Node v20 + updated dependencies (#235) * Minor dep updates * Husky updated * Major and breaking updates * Use Node v20 * Fix Textarea outline * Update inputs disabled bg color * Bump SDS to v2.0.0-beta.9 * Accent colors updated + form element success message (#237) * Updated accent colors * Form element success message prop * Bump SDS to v2.0.0-beta.10 * Textarea copy text button (#238) * Bump SDS to v2.0.0-beta.11 * Label info text + updated Tooltip colors (#240) * Bump SDS to v2.0.0-beta.12 * Label info link + update Tooltip theme setting (#242) * Label info link + update Tooltip theme setting * Select and Textarea preview updated * Bump SDS to v2.0.0-beta.13 * update <textarea/>'s footer to be conditional (#244) Co-authored-by: Jeesun Kim <jeesunkim@Jeesuns-MacBook-Pro.local> * Update Alert + Button + Floater (#251) * Small Select tweaks * Alert icon + title letter spacing * Button: onClick action tooltip * Bump SDS to v2.0.0-beta.14 * Use CopyText in input copy button * Bump SDS to v2.0.0-beta.15 * enable `isFilled` on <Notification/> (#258) * Bump SDS to v2.0.0-beta.16 * Code: update line height (#259) * Fix floater z-index + input and textarea fixes (#260) * Bump SDS to v2.0.0-beta.17 * Updated dependencies (#261) * Updated dependencies * Cleanup * Cleanup * Trigger PR Preview * allow Toggle to be tabbed and add focus styling (#263) * Prep for v3 launch (#267) * CopyText updated (#230) * CopyText updated * Fix CSS var * Bump SDS to v1.1.3 * Create codeql.yml (#245) * Bump version to 3.0.0 --------- Co-authored-by: Kanwalpreet Dhindsa <kpdhindsa@gmail.com> --------- Co-authored-by: jeesun 지선 <jeesunikim@users.noreply.github.com> Co-authored-by: Jeesun Kim <jeesunkim@Jeesuns-MacBook-Pro.local> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Kanwalpreet Dhindsa <kpdhindsa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Info text (in tooltip)
Info link (opens in new window)
