add guide for extending a persistent entry and contract using the javascript sdk #1163
Conversation
|
Heya @Mackenzie-OO7! Thank you for another great submission. Apologies for the delay in review, we'll get to this ASAP! |
briwylde08
requested review from
carstenjacobsen and
anataliocs
and removed request for
ElliotFriend
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Hi @Mackenzie-OO7 - thanks again so much for your contributions! Have you been able to look at the feedback yet? |
There was a problem hiding this comment.
Please review:
https://developers.stellar.org/docs/learn/encyclopedia/storage/state-archival#extendfootprintttlop
Operation.extendFootprintTtl The Read-only set needs to contain the ledger key and the read/write section needs to be empty
ExtendFootprintTTLOp is a Soroban operation that will extend the live until ledger of the entries specified in the read-only set of the footprint. The read-write set must be empty.
hi! somehow I missed this, but I see there's new feedback now and I'll get to it. thanks for the reminder. |
|
apologies for the delay, I had some issues with my machine, but I’ve sorted that out now. |
|
Hi @Mackenzie-OO7! Just checking, is this ready for re-review? |
Yes it is |
|
@Shaptic thanks for reviewing! i've made the suggested changes |
|
@anataliocs can you check your requested changes and see if they've been addressed and close that comment so we can merge this? Thank youuuuuu! |
briwylde08
dismissed
anataliocs’s stale review
PR has been approved, removing so we can merge
closes #610