Conversation
|
Preview is available here: |
|
Hi @elizabethengelman! Is 1138 an issue somewhere? |
@briwylde08 Good question - I was doing this work as a follow up to Jane's PR that was addressing #1138 |
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
Looks great! I left a couple minor thoughts/questions, but I think it's pretty close to ready as-is! Thanks @elizabethengelman!!
| Contract inputs must not be references. | ||
|
|
||
| The `#[contract]` attribute designates the Contract struct as the type to which contract functions are associated. This implies that the struct will have contract functions implemented for it. | ||
| The `#[contract]` attribute designates the `HelloContract` struct as the type to which contract functions are associated. This implies that the struct will have contract functions implemented for it. |
There was a problem hiding this comment.
The CLI (at least v22.2.0, which I think is the current version) creates a struct called Contract.
Edit: Never mind, we're talking about the astro template, not the stellar contract init command... 🤦🏻♂️
Edit Edit: Oh, wait, no... This page isn't talking about the astro template, right? We might need to modify instances of HelloContract to just Contract then?
There was a problem hiding this comment.
Good catch! You're right, the current version of the CLI just has Contract.
I have a branch to update the code that stellar contract init creates to make it HelloContract so that it matches the soroban-examples repo but I forgot to open a PR!
I'll revert this back to Contract for now. And we can make this change when the cli change is also updated. I can open 2 new PRs.
Co-authored-by: Elliot Voris <elliot@voris.me>
|
Preview is available here: |
|
@ElliotFriend just made the updates from your review - thank you! I also noticed one more small thing that needed to be fix, and pushed up a commit for that as well. |
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
looks great @elizabethengelman!! Thanks so much!!
4 participants
Some additional fixes/updates that i noticed while looking into 1138
getting start
contract bindingscommand works in dapp-frontend.mdxinitcommand, and how the--nameflag worksdapp-frontend.mdx
.stellarover into theirst-soroban-appdirectory so we can reuse the deployments from the first secionscontract bindingsexample