Improve build section #1336
Open
Improve build section #1336
+137
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art contract overview page and setup page.
I worked on the Introduction page, Write Smart contract overview page and setup page.
|
Hi there, @Ileolami! Thanks for submitting the PR! Making things more readable and better structured is always so appreciated! I'll review the changes and get back with you. Thanks again! |
briwylde08
reviewed
Mar 24, 2025
docs/build/README.mdx
Outdated
|
|
||
| :::tip | ||
|
|
||
| While defining rules and logic of the contract, developers must be security conscious to avoid vulnerabilities such as reentrancy attacks, integer overflows, access control flaws, and other exploits that could compromise the integrity and functionality of the smart contract. |
There was a problem hiding this comment.
Soroban doesn't allow reentrancy attacks. So it is probably a good idea to not even mention it. @ElliotFriend for confirmation this is correct.
|
|
||
| ## Install the Stellar CLI | ||
|
|
||
| The [Stellar CLI](https://github.com/stellar/stellar-cli) can execute smart contracts on futurenet, testnet, mainnet, as well as in a local sandbox. | ||
|
|
||
| :::info | ||
|
|
||
| The latest stable release is [v{latestVersion}](https://github.com/stellar/stellar-cli/releases/latest). |
There was a problem hiding this comment.
This is showing as v0.0.0 for me when it should be (at the time of writing) 22.6.0. Maybe it's just a preview error?
|
|
||
| **Need help finding what you're looking for?** | ||
| ## Soroban FAQs |
There was a problem hiding this comment.
I'm fine with these being drop-downs but some of the tables have "Details" as a heading.
There was a problem hiding this comment.
This problem is coming from the formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the build section, I worked on the introduction page and writing smart contract section(overview and setup page).
These are what I did: