Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Golang client for Stellar RPC #349

Merged
merged 11 commits into from
Jan 30, 2025
Merged

Add Golang client for Stellar RPC #349

merged 11 commits into from
Jan 30, 2025

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Jan 22, 2025 •
edited
Loading

Closes #326

@2opremio 2opremio requested review from Shaptic and tamirms January 22, 2025 13:34
Shaptic
Shaptic reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work. internal/ is way cleaner now and the public/private division is much easier to understand. Just a coupla nits below but otherwise this LGTM!

client/main.go Outdated Show resolved Hide resolved
client/main.go Show resolved Hide resolved
Shaptic
Shaptic approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to you to fix the golint errors before merging, but otherwise this LGTM 👍

@2opremio 2opremio merged commit be7702a into stellar:main Jan 30, 2025
19 checks passed
@2opremio 2opremio deleted the client branch January 30, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

@tamirms tamirms Awaiting requested review from tamirms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create and release a golang RPC client
2 participants
@2opremio @Shaptic