Add operation index to event result #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Apr 16, 2025
| @@ -25,6 +25,7 @@ type EventInfo struct { | |||
| LedgerClosedAt string `json:"ledgerClosedAt"` | |||
| ContractID string `json:"contractId"` | |||
| ID string `json:"id"` | |||
| OpIndex uint32 `json:"operationIndex"` | |||
There was a problem hiding this comment.
I think we should also include the transaction index . With the ledger sequence, transaction index, and operation index I think we have all the information needed to sort events
There was a problem hiding this comment.
Might as well! Done in 49fd1e8. Thoughts on naming? I considered applicationOrder to match getTransaction...
tamirms
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See #371: events within a transaction no longer necessarily correspond to a single operation.
Why
Closes #371.
Known limitations
n/a