Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add types for sep-43 interface #185

Merged
merged 3 commits into from
Dec 11, 2024
Merged

add types for sep-43 interface #185

merged 3 commits into from
Dec 11, 2024

Conversation

piyalbasu
Copy link
Contributor

aristidesstaffieri
aristidesstaffieri reviewed Dec 10, 2024
View reviewed changes
@stellar/typescript-wallet-sdk/src/walletSdk/Types/sep43.ts Outdated
submitUrl?: string;
},
): Promise<
{ signedTxXdr: string; signerAddress?: string } & { error?: Error }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like maybe signedAddress is not optional in the spec, should it be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch - it should not be optional. I'll fix this here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks. I think this applies to the other instance of signerAddress as well.

@piyalbasu piyalbasu merged commit a0a4a08 into release/1.9.0 Dec 11, 2024
5 of 6 checks passed
@piyalbasu piyalbasu deleted the feature/add-sep-43-interface branch December 11, 2024 22:24
piyalbasu added a commit that referenced this pull request Feb 19, 2025
@piyalbasu
Release/1.9.0 (#194)
416d6e0 
* add types for sep-43 interface (#185)

* add types for sep-43 interface

* make signerAddress a required return value

* make all returned signerAddress required

* export sep-43 types (#186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CassioMG CassioMG CassioMG approved these changes

@aristidesstaffieri aristidesstaffieri aristidesstaffieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piyalbasu @CassioMG @aristidesstaffieri