Repository navigation
Tests/extensive repo testing - #32
Merged
Merged
Conversation
`pnpm test` was never wired into CI, so the two existing suites (format.test.ts, score-series.test.ts) only ran when someone remembered locally. CI also pinned Node 20, which cannot run *.test.ts at all — native TypeScript stripping needs 22.18+ — so adding the step without the version bump would have failed outright. - ci.yml: Node 20 -> 24, plus a `pnpm run test` step after typecheck. Tests run last: they resolve workspace deps through dist/, so they need the build step above them. - core/adapters/db/indexer: add a `test` script each. Root `pnpm test` fans out with --if-present, so without these four the backend packages silently contributed nothing and always passed. Verified `node --test` exits 0 on a zero-match glob, so these are safe to land before their first test file exists. Its glob also skips node_modules, which is why adapters' flat "**/*.test.ts" is safe. - .nvmrc + engines.node >= 22.18, so contributors don't land on a version that can't run the suite. - CONTRIBUTING: the prerequisite said "Node 20+", now wrong given `pnpm test` is part of the pre-PR flow; both command lists now include it. No new tests. This only makes the existing ones run on every PR. Verified: format:check, lint, typecheck, test all pass (22 tests, exit 0). `pnpm -r build` is NOT verified here — a next dev server was up on the same checkout, and running it would corrupt the shared .next. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensive repo testing