Repository navigation
Try to fix some problems I found while testing with copier - #6
ClausKlein wants to merge 5 commits into
Conversation
ClausKlein
commented
Jul 26, 2026
Sync with pre-cmmmit config files versions with format_project.sh
Update README.md
77646a0 to
5a7af14
Compare
| rm "examples/identity_as_default_projection.cpp"; | ||
| mv "tests/beman/{{ project_name }}/identity.test.cpp" "tests/beman/{{ project_name }}/todo.test.cpp"; | ||
| git ls-remote https://github.com/bemanproject/exemplar.git HEAD | awk '{print $1}' > .exemplar_version; | ||
| grep _commit: .copier-answers.yml | awk '{print $2}' > .exemplar_version; |
There was a problem hiding this comment.
To be correct: this allow to test a clone of this repo too with CI
There was a problem hiding this comment.
Are any of the tools that look at .exemplar_version going to be unhappy if that's not a commit on https://github.com/bemanproject/exemplar.git ?
I don't see anything that reads it in https://github.com/search?q=org%3Abemanproject++.exemplar_version&type=code so it shouldn't, or it's someone else's problem.
steve-downey
left a comment
There was a problem hiding this comment.
Two things, one important,
- the command in the README to run copier needs a tweak
- I'd rather fix the versions on main, first. PR shortly for that.
| # NOTE: import std; needs at leased cmake v3.31! CK | ||
| cmake_version: ["~3.31.10", "~4.0.3", "~4.1.3", "~4.2.3", "~4.3.2", "~4.4.0"] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: lukka/get-cmake@latest | ||
| with: | ||
| cmakeVersion: ${{ matrix.cmake_version }} # ~3.30.9 --> use most recent 3.30.x version |
There was a problem hiding this comment.
Note: This seems better to me.
ed28f6c to
3cf358f
Compare
|
@steve-downey It generates this code: set_target_properties(beman.my_project_name PROPERTIES CXX_MODULE_STD ON)
target_compile_features(beman.my_project_name PUBLIC cxx_std_23)I added an automatic https://github.com/ClausKlein/turbo-adventure/actions/runs/30287993003 To fix the CI tests it must be changed to: diff --git a/CMakeLists.txt b/CMakeLists.txt
index c51a2b4..8670b72 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -63,7 +63,7 @@ if(BEMAN_MY_PROJECT_NAME_USE_MODULES)
"${CMAKE_CURRENT_BINARY_DIR}/include"
)
set_target_properties(beman.my_project_name PROPERTIES CXX_MODULE_STD ON)
- target_compile_features(beman.my_project_name PUBLIC cxx_std_23)
+ target_compile_features(beman.my_project_name PUBLIC cxx_std_${CMAKE_CXX_STANDARD})
else()
target_sources(
beman.my_project_name |
|
And we should add this I think pre-commit hooks: |
|
Please note too https://github.com/ClausKlein/turbo-adventure/pull/2/changes IMHO: we should add some notes about to update with copier in CONTRIBUTING.md |