Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle comma delimited locations. #123

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Handle comma delimited locations. #123

merged 1 commit into from
Jun 6, 2016

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Oct 19, 2015

I decided to look at the code after filing #122, this seems to work fine.

@stevekinney
Copy link
Owner

I want to merge this, but there is a conflict—could you rebase?

@jmhobbs
Copy link
Contributor Author

jmhobbs commented Nov 13, 2015

Done!

However, I'm concerned there is a bug in there now. I re-ran map_readme.rb and I saw duplicate geocoder requests for the same address for some locations;

Geocoder: HTTP request being made for http://maps.googleapis.com/maps/api/geocode/json?address=254+Crown+St%2C+Santa+Monica__&language=en&sensor=false
Geocoder: HTTP request being made for http://maps.googleapis.com/maps/api/geocode/json?address=254+Crown+St%2C+New+Haven&language=en&sensor=false
Geocoder: HTTP request being made for http://maps.googleapis.com/maps/api/geocode/json?address=254+Crown+St%2C+South+Bend&language=en&sensor=false
Geocoder: HTTP request being made for http://maps.googleapis.com/maps/api/geocode/json?address=254+Crown+St%2C+NYC&language=en&sensor=false
Geocoder: HTTP request being made for http://maps.googleapis.com/maps/api/geocode/json?address=254+Crown+St%2C+Dar+Es+Salaam&language=en&sensor=false

I think there is something up in the city matching code, but I'm not sure how to grok that.

@stevekinney stevekinney merged commit 88076cf into stevekinney:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants