Add a google map and index to view

[ETNOL]

issue #62
This is the initial conversion of my google map script to consume the pizzeria geojson and spit out a map full of markers.

Its js code from my first days of dev so it could a major refactor which I'd be happy to perform soon. I also brought in psQuery to handle the ajax request because I'm ajax-lazy. I think it can be branched to a 'gh-pages' branch in the current state and be available through Github pages at http://stevekinney/github.io/pizza/

[alanbsmith]

This is cool! Thanks for the PR, @ETNOL. We're using pizza_map.geojson for our map. Our goal for PRs is to have a fairly small core of central functionality and also to display example client applications that consume this dataset.

I think this PR really fits well into that second category. So we had two ideas, one would be to build this out into a separate client application that uses this data, or we could create an 'examples' folder where this could live and serve as an example for people wanting to build something with this dataset.

Let us know what you think and we can go from there. And thanks again!

[alanbsmith]

This looks great. The only thing I would change is this line. I would set the url to './pizza_map.geojson' so anyone could grab from their dataset when they pull it down.

[ETNOL]

Either option sounds good! My reasoning for using github to host the json
data was to make it easier to keep updated. I'd probably want to use the
original source repo instead of my fork though so I wouldn't need to pull
down updates. My original map on my personal site wasn't geared towards
anything specific so I might just replace it with this instead. If I do,
should I make a pull request with its url in an examples.md or just drop
the code in a folder like "examples/pizza-map/{codebase}"?

On Fri, Aug 21, 2015 at 3:31 PM, Alan B Smith [email protected]
wrote:

In js/map.js
#82 (comment):

•    props.pizzeria +
  

•    '<br />' +
  

•    props.address +
  

•    '<br />' +
  

•    props.city +
  

•    '<br />' +
  

•    '<a href=' + props.website + '>' + props.website + '</a>'
  

•  '</div>';
  

• };
• return setMarker;
• };

• window.onload = function () {
• psQuery.ajax({url: 'https://raw.githubusercontent.com/ETNOL/pizza/master/pizza_map.geojson', success: jsonSuccess})

This looks great. The only thing I would change is this line. I would set
the url to './pizza_map.geojson' so anyone could grab from their dataset
when they pull it down.

—
Reply to this email directly or view it on GitHub
https://github.com/stevekinney/pizza/pull/82/files#r37680332.

[cluhring]

Hey @ETNOL - I just added a d3_map directory into "examples/maps/" - Please feel free to throw your google_map directory in there with mine.

[stevekinney]

Hey y'all—what's the status with this PR? Is it ready to go?

[stevekinney]

Just checking in to see if this is ready to merge. 👼

[ETNOL]

There is a D3 map in the codebase so lets leave this out.