Create an action client/server implementation#4
Open
stevendes wants to merge 8 commits intocolor_pluginfrom
Open
Create an action client/server implementation#4stevendes wants to merge 8 commits intocolor_pluginfrom
stevendes wants to merge 8 commits intocolor_pluginfrom
Conversation
Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type changed xacro files Modifying the original plugin to detect RGB Added the plugin in the two color sensors from previous PR Adding the files for the sensor plugin Add action messages Addressed some comments and added realistic mesh Addressed requested changes, added comments Fixed publication in sensor plugin
Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type changed xacro files Modifying the original plugin to detect RGB Added the plugin in the two color sensors from previous PR Adding the files for the sensor plugin Add action messages Addressed some comments and added realistic mesh Addressed requested changes, added comments
Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type changed xacro files Modifying the original plugin to detect RGB Added the plugin in the two color sensors from previous PR Adding the files for the sensor plugin Add action messages Addressed some comments and added realistic mesh Addressed requested changes, added comments Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type changed xacro files Modifying the original plugin to detect RGB Added the plugin in the two color sensors from previous PR Adding the files for the sensor plugin Add action messages Addressed some comments and added realistic mesh Addressed requested changes, added comments Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type changed xacro files Modifying the original plugin to detect RGB Added the plugin in the two color sensors from previous PR Adding the files for the sensor plugin Add action messages Addressed some comments and added realistic mesh Addressed requested changes, added comments Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type changed xacro files Modifying the original plugin to detect RGB Added the plugin in the two color sensors from previous PR Adding the files for the sensor plugin Add action messages Addressed some comments and added realistic mesh Addressed requested changes, added comments Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type Add color sensor Applied changes requested Adressed the issues commented Fixed type changed xacro files Modifying the original plugin to detect RGB Added the plugin in the two color sensors from previous PR Adding the files for the sensor plugin Add action messages Addressed some comments and added realistic mesh Addressed requested changes, added comments Change action file Create a controller to follow lines in autorace map Solved color sensor problem, added action server and client Changed actionlib related files Fixing conflicts Added launch file Added comments to the controller
Owner
Author
|
@ernestmc Ready for review! |
ernestmc
suggested changes
Nov 27, 2019
Comment on lines
+94
to
+95
| self.move_forward() | ||
| self.stuck_flag = False |
There was a problem hiding this comment.
Can this be replaced by calling solve_stuck()?
Comment on lines
+107
to
+111
| if not self.stuck_flag: | ||
| self.stuck_timer = rospy.Time.now() | ||
| self.stuck_flag = True | ||
| if rospy.Time.now() - self.stuck_timer > rospy.Duration(5, 0) and self.stuck_flag: | ||
| self.solve_stuck() |
There was a problem hiding this comment.
you are doing the same as above. Looks like it is worth putting all this inside the solve_stuck() method?
Owner
Author
There was a problem hiding this comment.
The flag is to record when the robot is not moving forward in a time, it get force to go forward a little bit, are you telling me to do that check in the solve_stuck() method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR was merged by mistake and closed, the original link is https://github.com/stevendes/create_autonomy/pull/3
Update
Created an action-client/action server implementation
Addressed all the comments from mentioned PR
How it works
Launch the autorace map from the ca_gazebo package
roslaunch ca_gazebo create_autorace.launchLaunch the robot controller, the action client and the action server from the ca_tools package
roslaunch ca_tools action_launch.launchThe
action_launch.launchfile accepts parameters for the goal, these are:goal_seconds,goal_pos_xandgoal_pos_y