Skip to content

(Closes #476) Put back testing with python 3.9#477

Merged
LonelyCat124 merged 7 commits intomasterfrom
476_python_3_9
Aug 29, 2025
Merged

(Closes #476) Put back testing with python 3.9#477
LonelyCat124 merged 7 commits intomasterfrom
476_python_3_9

Conversation

@arporter
Copy link
Member

No description provided.

@arporter arporter self-assigned this Jul 17, 2025
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.16%. Comparing base (afb9da7) to head (f25b549).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          86       86           
  Lines       13752    13752           
=======================================
+ Hits        12674    12675    +1     
+ Misses       1078     1077    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter
Copy link
Member Author

Weirdly, CodeCov is saying that there are indirect coverage changes but I can't see how that has happened. The code in question is actually unreachable so I have removed it.

@arporter
Copy link
Member Author

Ready for review from anyone (@hiker @sergisiso @LonelyCat124).

Copy link

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arporter, one small comment as I thinkwe should keep 3.10 testing as we'll move to that once 3.9 is retired.

@LonelyCat124 LonelyCat124 added reviewed with actions PR has been reviewed and is back with developer and removed ready for review labels Jul 23, 2025
@arporter arporter added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Jul 29, 2025
@arporter
Copy link
Member Author

I've added back testing with 3.10 and all is well. Ready for another look now.

@LonelyCat124 LonelyCat124 added ready for merge PR is waiting on final CI checks before being merged. and removed ready for review labels Aug 29, 2025
@LonelyCat124
Copy link

Looks good to me now, think we can merge

@LonelyCat124 LonelyCat124 self-requested a review August 29, 2025 14:05
@LonelyCat124 LonelyCat124 merged commit d13e4fa into master Aug 29, 2025
6 checks passed
@LonelyCat124 LonelyCat124 deleted the 476_python_3_9 branch August 29, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for merge PR is waiting on final CI checks before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants