Skip to content

Conversation

@peterhuene
Copy link
Contributor

@peterhuene peterhuene commented Oct 1, 2025

The problem occurs when:

  1. Logging with DEBUG level (i.e. -vv).
  2. Using the TES backend.
  3. Using inputs that are remote URLs.

There's a debug! log message in task evaluation that logs what inputs have been downloaded and mapped to.

The logging assumes that if the input is remote, it has been downloaded (i.e. localized).

But that's not the case with the TES backend; the input can be remote and not downloaded because task execution occurs remotely.

The fix is to properly add a match case to handle it.

Before submitting this PR, please make sure:

For external contributors:

  • You have read the wdl crates' CONTRIBUTING guide in its entirety.
  • You have not used AI on any parts of this pull request.

For all contributors:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have added an entry in the CHANGELOG (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).
  • You have either (a) made a PR to the next branch in the sprocket.bio repository [if you are a Sprocket team member] or (b) have suggested any changes you think need to be made to sprocket.bio in the description of your PR [if you are an external contributor].

For PRs containing lint rule changes:

  • You have updated any and all effected entries within RULES.md.
  • You have added a test case in crates/wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.

The problem occurs when:

1. Logging with DEBUG level (i.e. `-vv`).
2. Using the TES backend.
3. Using inputs that are remote URLs.

There's a `debug!` log message in task evaluation that logs what inputs have
been downloaded and mapped to.

The logging assumes that if the input is remote, it has been downloaded (i.e.
localized).

But that's not the case with the TES backend; the input can be remote and _not_
downloaded because task execution occurs remotely.

The fix is to properly add a match case to handle it.
@peterhuene peterhuene self-assigned this Oct 1, 2025
@peterhuene peterhuene requested a review from a team as a code owner October 1, 2025 21:26
@peterhuene peterhuene requested review from claymcleod and removed request for a team October 1, 2025 21:26
@peterhuene peterhuene merged commit 00eba73 into stjude-rust-labs:main Oct 2, 2025
20 checks passed
@peterhuene peterhuene deleted the fix-panic branch October 2, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants