Merge #559

559: update ci, clippy & release 0.14 r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <[email protected]>

.github/workflows/ci.yml

@@ -37,18 +37,15 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-
-      - uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: ${{ matrix.rust }}
-          target: thumbv7em-none-eabihf
-          override: true
+      - name: Use the latest ${{ matrix.rust }} rustc
+        run: rustup update ${{ matrix.rust }} && rustup default ${{ matrix.rust }}
+      - name: Add Cortex-M4F target
+        run: rustup target add thumbv7em-none-eabihf
 
       - name: Cache Dependencies
         uses: Swatinem/rust-cache@v2
         with:
-          key: pac-v0.15.1-${{ matrix.mcu }}
+          key: v0.14.0-${{ matrix.mcu }}
 
       - uses: actions-rs/cargo@v1
         with:

.github/workflows/clippy.yml

@@ -9,19 +9,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-
-      - uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          target: thumbv7em-none-eabihf
-          override: true
-          components: clippy
+      - name: Use the latest stable rustc
+        run: rustup update stable && rustup default stable
+      - name: Add Cortex-M4F target
+        run: rustup target add thumbv7em-none-eabihf
 
       - name: Cache Dependencies
         uses: Swatinem/rust-cache@v2
         with:
-          key: pac-v0.15.1
+          key: v0.14.0
 
       - uses: actions-rs/clippy-check@v1
         with:

.github/workflows/rustfmt.yml

@@ -11,12 +11,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-          components: rustfmt
+      - name: Use the latest stable rustc
+        run: rustup update stable && rustup default stable
+
       - uses: actions-rs/cargo@v1
         with:
           command: fmt

CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [v0.14.0] - 2022-12-12
+
 ### Changed
 
  - Add missing timer pins [#536]
@@ -70,18 +72,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 [#515]: https://github.com/stm32-rs/stm32f4xx-hal/pull/515
 [#517]: https://github.com/stm32-rs/stm32f4xx-hal/pull/517
 [#519]: https://github.com/stm32-rs/stm32f4xx-hal/pull/519
+[#527]: https://github.com/stm32-rs/stm32f4xx-hal/pull/527
 [#529]: https://github.com/stm32-rs/stm32f4xx-hal/pull/529
 [#536]: https://github.com/stm32-rs/stm32f4xx-hal/pull/536
 [#534]: https://github.com/stm32-rs/stm32f4xx-hal/pull/529
+[#535]: https://github.com/stm32-rs/stm32f4xx-hal/pull/535
 [#540]: https://github.com/stm32-rs/stm32f4xx-hal/pull/540
 [#542]: https://github.com/stm32-rs/stm32f4xx-hal/pull/542
-[#527]: https://github.com/stm32-rs/stm32f4xx-hal/pull/527
 [#551]: https://github.com/stm32-rs/stm32f4xx-hal/pull/551
 [#552]: https://github.com/stm32-rs/stm32f4xx-hal/pull/552
 [#553]: https://github.com/stm32-rs/stm32f4xx-hal/pull/553
 [#554]: https://github.com/stm32-rs/stm32f4xx-hal/pull/554
 [#555]: https://github.com/stm32-rs/stm32f4xx-hal/pull/555
 [#556]: https://github.com/stm32-rs/stm32f4xx-hal/pull/556
+[#557]: https://github.com/stm32-rs/stm32f4xx-hal/pull/557
 
 ## [v0.13.2] - 2022-05-16
 
@@ -743,7 +747,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Support for stm32f407 and stm32f429.
 
-[Unreleased]: https://github.com/stm32-rs/stm32f4xx-hal/compare/v0.13.2...HEAD
+[Unreleased]: https://github.com/stm32-rs/stm32f4xx-hal/compare/v0.14.0...HEAD
+[v0.14.0]: https://github.com/stm32-rs/stm32f4xx-hal/compare/v0.13.2...v0.14.0
 [v0.13.2]: https://github.com/stm32-rs/stm32f4xx-hal/compare/v0.13.1...v0.13.2
 [v0.13.1]: https://github.com/stm32-rs/stm32f4xx-hal/compare/v0.13.0...v0.13.1
 [v0.13.0]: https://github.com/stm32-rs/stm32f4xx-hal/compare/v0.12.0...v0.13.0

Cargo.toml

@@ -20,10 +20,10 @@ license = "0BSD"
 name = "stm32f4xx-hal"
 readme = "README.md"
 repository = "https://github.com/stm32-rs/stm32f4xx-hal"
-version = "0.13.2"
+version = "0.14.0"
 
 [package.metadata.docs.rs]
-features = ["stm32f429", "usb_fs", "can", "i2s", "fsmc_lcd", "rtic"]
+features = ["stm32f429", "usb_fs", "can", "i2s", "fsmc_lcd", "rtic", "defmt"]
 targets = ["thumbv7em-none-eabihf"]
 
 [dependencies]
@@ -62,7 +62,7 @@ optional = true
 
 [dev-dependencies]
 defmt = "0.3.2"
-defmt-rtt = "0.3.2"
+defmt-rtt = "0.4.0"
 panic-probe = { version = "0.3.0", features = [ "print-defmt" ] }
 panic-semihosting = "0.6.0"
 cortex-m-semihosting = "0.5.0"

src/bb.rs

@@ -47,5 +47,5 @@ pub unsafe fn write<T>(register: *const T, bit: u8, set: bool) {
 
     let bit = bit as usize;
     let bb_addr = (PERI_BIT_BAND_BASE + (addr - PERI_ADDRESS_START) * 32) + 4 * bit;
-    ptr::write_volatile(bb_addr as *mut u32, if set { 1 } else { 0 });
+    ptr::write_volatile(bb_addr as *mut u32, u32::from(set));
 }

src/i2c.rs

@@ -551,7 +551,7 @@ impl<I2C: Instance, PINS> I2c<I2C, PINS> {
             for op in ops {
                 // 2. Execute previous operations.
                 match &mut prev_op {
-                    Operation::Read(rb) => self.read_bytes(*rb)?,
+                    Operation::Read(rb) => self.read_bytes(rb)?,
                     Operation::Write(wb) => self.write_bytes(wb.iter().cloned())?,
                 };
                 // 3. If operation changes type we must generate new start
@@ -592,7 +592,7 @@ impl<I2C: Instance, PINS> I2c<I2C, PINS> {
             for op in ops {
                 // 2. Execute previous operations.
                 match &mut prev_op {
-                    Operation::Read(rb) => self.read_bytes(*rb)?,
+                    Operation::Read(rb) => self.read_bytes(rb)?,
                     Operation::Write(wb) => self.write_bytes(wb.iter().cloned())?,
                 };
                 // 3. If operation changes type we must generate new start

src/rtc.rs

@@ -505,7 +505,7 @@ fn decode_day(dr: &dr::R) -> u8 {
 
 #[inline(always)]
 fn decode_month(dr: &dr::R) -> u8 {
-    let mt: u8 = if dr.mt().bit() { 1 } else { 0 };
+    let mt = u8::from(dr.mt().bit());
     bcd2_decode(mt, dr.mu().bits()) as u8
 }