fix: fix library name absolufy #289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix library name absolufy in requirements-dev.txt
- Fix critical typo: torch.optim.adam -> torch.optim.Adam - Improve exception handling: bare except -> specific json.JSONDecodeError - Add proper NotImplementedError messages for placeholder classes - Add missing DatasetDict type hint in text_dataset.py - Add reference to AGENTS.md in CONTRIBUTING.md
MarcosRiveraMartinez
approved these changes
Sep 20, 2025
|
|
||
| def _validate(self): | ||
| pass | ||
| raise NotImplementedError |
There was a problem hiding this comment.
It is a good practice to return an exception instance instead of the class. It works, but I would use NotImplementedError()
| pass | ||
| logger (bool, optional): To be setup with a Pytorch Lightning logger when implemented. | ||
| """ | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Same here, I would return the instance instead of the class
|
|
||
| def generate( | ||
| self, | ||
| texts: Optional[Union[List[str], str]] = None, | ||
| dataset: Optional[Text2ImageDataset] = None, | ||
| ): | ||
| pass | ||
| raise NotImplementedError |
|
|
||
| def save(self, path: Union[str, Path]): | ||
| pass | ||
| raise NotImplementedError |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix library name absolufy in requirements-dev.txt