https://issues.redhat.com/browse/ACM-20220 Access apiserver token doc #7951
Conversation
| @@ -40,6 +40,7 @@ Learn about new features and enhancements that come with the {mce-short} install | |||
| Learn about new features and enhancements for Cluster lifecycle with {mce-short}. | |||
|
|
|||
| - You can now define a unique mirror registry for each cluster. To learn more, see xref:../assisted_installer#config-mirror-reg-cluster[Configuring mirror registries for each cluster] | |||
| - You can now access the managed cluster `kube-apiserver` by using a hub cluster user token. To learn more, see xref:../cluster_proxy_addon_use#access-kube-apiserver-hub-token[Accessing the managed cluster `kube-apiserver` by using a hub cluster user token]. | |||
There was a problem hiding this comment.
Should this be "a managed cluster's kube-apiserver" as it points to some target managed cluster?
There was a problem hiding this comment.
Yes, "managed cluster's kube-apiserver" would be more accurate.
There was a problem hiding this comment.
We can't use a possessive as per the style guide in this case. What we have in the PR would match the style requirements, but if it's not accurate enough, would "kube-apiserver of the managed cluster" be better/more accurate?
There was a problem hiding this comment.
Updated @xuezhaojun @dtthuynh !
|
/lgtm |
|
All comments addressed, merging after peer review |
| [#use-cluster-proxy-addon] | ||
| = Using cluster proxy add-ons | ||
|
|
||
| Use cluster proxy add-ons to access the managed cluster kube API server or managed cluster services by using different methods. See the following topics to learn more about the different ways you can use cluster proxy add-ons. |
There was a problem hiding this comment.
Please add a link to the topics. I understand that these topics are in the rest of the section but I'm expecting to see the relevant topics listed right after this intro sentence ("See the following topics..."
|
|
||
| See the following example that binds the `get` and `list` permissions for pods to the user `developer`: | ||
|
|
||
| [source,yaml] |
There was a problem hiding this comment.
Don't you need a + here?
There was a problem hiding this comment.
It's only needed when it comes after a step (.)
Co-authored-by: Alexandra Molnar <[email protected]>
Co-authored-by: Alexandra Molnar <[email protected]>
Co-authored-by: Alexandra Molnar <[email protected]>
Co-authored-by: Alexandra Molnar <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amolnar-rh, oafischer, xuezhaojun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2.14 only.
Checklist considered.