Skip to content

[TEST] Translation - Crowdin#549

Closed
diazdesandi wants to merge 2 commits intodevelopmentfrom
test/test-workflow
Closed

[TEST] Translation - Crowdin#549
diazdesandi wants to merge 2 commits intodevelopmentfrom
test/test-workflow

Conversation

@diazdesandi
Copy link
Copy Markdown
Collaborator

@diazdesandi diazdesandi commented May 8, 2026

Testing it does not auto-close Crowdin PRs.

Summary by CodeRabbit

  • Documentation
    • Updated Spanish translations for improved clarity in app settings descriptions and menu bar visibility controls.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Spanish translations are updated for two UI strings in the localization file: one for external applications accessing settings via thaw:// URLs, and another for showing hidden menu bar elements. Both changes modify only the Spanish translation values with no logic or functionality alterations.

Changes

Spanish Localization Updates

Layer / File(s) Summary
Spanish Translation Updates
Thaw/Resources/Localizable.xcstrings
Spanish translation value updated for external app access via thaw:// URLs (line 5308). Spanish translation value updated for menu bar element visibility control (line 5546).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • stonerl/Thaw#510: Updates Spanish translations for the same localization file including overlapping string entries.
  • stonerl/Thaw#459: Modifies related localization entries in Localizable.xcstrings, including descriptions for app whitelisting.
  • stonerl/Thaw#289: Adds and adjusts Spanish translations across Localizable.xcstrings.

Suggested labels

translation

Suggested reviewers

  • stonerl

Poem

🐰 Two Spanish phrases now shine bright,
Like whispers in the Thaw midnight.
URLs and menus speak anew,
In castellano, fresh and true! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it only states 'Testing it does not auto-close Crowdin PRs' without addressing required template sections like PR Type, current/new behavior, or the checklist items. Complete the PR description by selecting the i18n/l10n PR Type, describing the current and new behavior for the Spanish translation updates, and reviewing the checklist items.
Title check ❓ Inconclusive The title '[TEST] Translation - Crowdin' is vague and generic; it uses a non-descriptive '[TEST]' prefix and 'Translation - Crowdin' which doesn't convey the specific nature of the localization changes made. Clarify the title to describe the actual changes, such as 'Update Spanish translations for external app permissions and menu bar visibility' or remove '[TEST]' and provide more specific context.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/test-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Thaw/Resources/Localizable.xcstrings`:
- Line 5546: The Spanish localization string in
Thaw/Resources/Localizable.xcstrings contains a typo: replace the word "mostar"
with "mostrar" in the value entry ("Siempre mostar los elementos ocultos de la
barra de menús en esta pantalla.") so it reads "Siempre mostrar los elementos
ocultos de la barra de menús en esta pantalla."; update the "value" entry
accordingly to correct the translation.
- Line 5308: Fix the typos in the Spanish localization string value currently
set as "Permtir que aplicaciones externas lean y modifiquen ajustes de %@ via
thaw:// URLs." — update the text to "Permitir que aplicaciones externas lean y
modifiquen ajustes de %@ vía thaw:// URLs." by correcting "Permtir" → "Permitir"
and "via" → "vía" in the Localizable.xcstrings entry (the string with value
containing thaw:// URLs).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9db91806-118c-418b-9c42-edcc2ea10c19

📥 Commits

Reviewing files that changed from the base of the PR and between ad4973a and 940ab5a.

📒 Files selected for processing (1)
  • Thaw/Resources/Localizable.xcstrings

"stringUnit" : {
"state" : "new",
"value" : "Allow external applications to read and modify %@ settings via thaw:// URLs."
"value" : "Permtir que aplicaciones externas lean y modifiquen ajustes de %@ via thaw:// URLs."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix typographical errors in Spanish translation.

The Spanish translation contains two typos:

  • "Permtir" should be "Permitir" (missing 'i')
  • "via" should be "vía" (requires accent mark in Spanish)
📝 Proposed correction
-            "value" : "Permtir que aplicaciones externas lean y modifiquen ajustes de %@ via thaw:// URLs."
+            "value" : "Permitir que aplicaciones externas lean y modifiquen ajustes de %@ vía thaw:// URLs."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"value" : "Permtir que aplicaciones externas lean y modifiquen ajustes de %@ via thaw:// URLs."
"value" : "Permitir que aplicaciones externas lean y modifiquen ajustes de %@ vía thaw:// URLs."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Thaw/Resources/Localizable.xcstrings` at line 5308, Fix the typos in the
Spanish localization string value currently set as "Permtir que aplicaciones
externas lean y modifiquen ajustes de %@ via thaw:// URLs." — update the text to
"Permitir que aplicaciones externas lean y modifiquen ajustes de %@ vía thaw://
URLs." by correcting "Permtir" → "Permitir" and "via" → "vía" in the
Localizable.xcstrings entry (the string with value containing thaw:// URLs).

"stringUnit" : {
"state" : "translated",
"value" : "Mostrar siempre los elementos ocultos de la barra de menús en esta pantalla."
"value" : "Siempre mostar los elementos ocultos de la barra de menús en esta pantalla."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix typographical error in Spanish translation.

The Spanish translation contains a typo: "mostar" should be "mostrar" (missing 'r').

📝 Proposed correction
-            "value" : "Siempre mostar los elementos ocultos de la barra de menús en esta pantalla."
+            "value" : "Siempre mostrar los elementos ocultos de la barra de menús en esta pantalla."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Thaw/Resources/Localizable.xcstrings` at line 5546, The Spanish localization
string in Thaw/Resources/Localizable.xcstrings contains a typo: replace the word
"mostar" with "mostrar" in the value entry ("Siempre mostar los elementos
ocultos de la barra de menús en esta pantalla.") so it reads "Siempre mostrar
los elementos ocultos de la barra de menús en esta pantalla."; update the
"value" entry accordingly to correct the translation.

@diazdesandi diazdesandi closed this May 8, 2026
@diazdesandi diazdesandi deleted the test/test-workflow branch May 8, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant