Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-schema-merge-allof): bump version #28

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

brendarearden
Copy link
Contributor

@brendarearden brendarearden commented Dec 14, 2023

Motivation and Context

stoplightio/elements#2419

description and summary key/values are being overridden when siblings to reference in an allOf

Description

Bumped version of json-schema-merge-allOf
The new version retains siblings of references if they are description or summary key/values

How Has This Been Tested?

Added a new test for an allOf schema that has a reference with a description sibling

Screenshot(s)/recordings(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@brendarearden brendarearden requested review from a team and daniel-white and removed request for a team December 14, 2023 18:24
BREAKING CHANGE: description and summary reference siblings will not get overwritten by description
and summary in the reference if exists
@brendarearden brendarearden changed the title chore: bump json-schema-merge-allOf version fix(json-schema-merge-allof): bump version Dec 14, 2023
@brendarearden brendarearden merged commit 44abda7 into master Dec 14, 2023
@brendarearden brendarearden deleted the chore/bump-version branch December 14, 2023 18:52
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants