fix: account/egress/get handler configuration #30
Conversation
| server.WithAdminCreds(cfg.AdminDashboardUser, cfg.AdminDashboardPassword), | ||
| server.WithPricing(cfg.ClientEgressUSDPerTiB, cfg.ProviderEgressUSDPerTiB), | ||
| server.WithPrincipalResolver(presolver), | ||
| server.WithPrincipalParser(parsePrincipal), |
There was a problem hiding this comment.
I'd love confirmation that it is expected that only Ed25519 keys are supported by default and this is the right approach.
There was a problem hiding this comment.
Not sure I underatand - you added RSA so I assume you've run into RSA keys?
Currenty in the browser RSA keys are generated by default, since ed25519 support did not exist when it was built.
There was a problem hiding this comment.
yes, I'm getting delegations signed with RSA keys from the web app. What I meant with my comment is that go-ucanto verifiers, by default, only handle ed25519 keys.
Are you saying I can set the client up in the browser to generate ed25519 keys instead? I think I'd prefer that, if ed25519 support is generally available across browsers now.
| func corsMiddleware(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| // Allow all origins | ||
| w.Header().Set("Access-Control-Allow-Origin", "*") |
There was a problem hiding this comment.
we'll want to restrict this once we know where the dashboard gets deployed
| server.WithAdminCreds(cfg.AdminDashboardUser, cfg.AdminDashboardPassword), | ||
| server.WithPricing(cfg.ClientEgressUSDPerTiB, cfg.ProviderEgressUSDPerTiB), | ||
| server.WithPrincipalResolver(presolver), | ||
| server.WithPrincipalParser(parsePrincipal), |
There was a problem hiding this comment.
Not sure I underatand - you added RSA so I assume you've run into RSA keys?
Currenty in the browser RSA keys are generated by default, since ed25519 support did not exist when it was built.
Ref. storacha/project-tracking#619
Fixes and tweaks found when testing the new
account/egress/gethandler.More specifically:
dynamodb:GetItemon the customers table, required for the newCustomerTable.Hasmethod.account/egress/get, similar to what the upload service does.