fix: test/doupload works again
#289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeja
requested review from
alanshaw,
hannahhoward and
volmedo
as code owners
This was referenced Jan 14, 2026
frrist
reviewed
Jan 16, 2026
test/doupload
Outdated
| echo "🎁 Generating new space" | ||
| output=$(guppy space generate | tee /dev/fd/3) | ||
| space=$(echo "$output" | grep 'Generated space:' | awk '{print $3}') | ||
| space=$(guppy space generate | tee /dev/fd/3 | tail -n 1) |
Member
There was a problem hiding this comment.
I think we can drop the tail bit maybe? Since the space did is written to stdout and all other output is written to stderr - really makes me want a json output option for things like this.
Member
Author
There was a problem hiding this comment.
Oh, wow, you're right, we can! Yeah, I want json too, it was just too much to manage in the first pass. I think we absolutely should do it, though.
frrist
approved these changes
Jan 16, 2026
I hadn't noticed that only the DID itself appears on stdout! That's much cleaner.
Peeja
force-pushed
the
fix/update-doupload
branch
from
1272870 to
87d1e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Dependency Tree
test/douploadworks again #289 👈This tree was auto-generated by Charcoal