Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: two important usage billing fixes #460

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: two important usage billing fixes #460

merged 1 commit into from
Feb 3, 2025

Conversation

travis
Copy link
Member

@travis travis commented Jan 31, 2025

  1. use a CID as an idempotency key - some Stripe usage billing reporting requests were failing because the space DID was much longer than we expected and the idempotency key cannot be more than 255 characters - we were sending ~450 characters in many cases

  2. properly configure the "on failure" queue for the usage table handler - the previous config didn't work, and no "on failure" destination was set for this, which is, I suspect, why we can't find any trace of some usage table insert hook invocations

1) use a CID as an idempotency key - some Stripe usage billing reporting requests were failing because the space DID was much longer than we expected and the idempotency key cannot be more than 255 characters - we were sending ~450 characters in many cases

2) properly configure the "on failure" queue for the usage table handler - the previous config didn't work, and no "on failure" destination was set for this, which is, I suspect, why we can't find any trace of some usage table insert hook invocations
@seed-deploy seed-deploy bot temporarily deployed to pr460 January 31, 2025 18:29 Inactive
Copy link

seed-deploy bot commented Jan 31, 2025

View stack outputs

Copy link
Contributor

@BravoNatalie BravoNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travis travis merged commit 8f16e6a into main Feb 3, 2025
3 checks passed
@travis travis deleted the fix/billing-cron branch February 3, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants