tests: Skip LVM VDO tests if 'vdoformat' is not available#1094
Conversation
LVM VDO still uses the vdoformat binary which might not be available everywhere. Related: storaged-project/udisks#1353
vojtechtrefny
force-pushed
the
master_vdo-test-vdoformat-skip
branch
from
5a14ad4 to
08a78e8
Compare
tbzatek
left a comment
tbzatek
left a comment
There was a problem hiding this comment.
I just worry that any missing dependency that could have been installed may pass silently undetected.
Yes, this a problem with all these skips, but I am not sure what to do with that. We might try to create some better summary for the tests and actually check the skipped tests, but that would be quite a lot of work. |
|
I've added "vdo" as test dependency for now. So there is no need to skip the test for Debian's sake: I very much appreciate it though, that you do care for Debian. |
It still makes sense to skip the test if vdo is not available. We need some way to be sure we are just not skipping all tests because of some CI infrastructure issue, but that's a different problem. |
3 participants
LVM VDO still uses the vdoformat binary which might not be available everywhere.
Related: storaged-project/udisks#1353