tests: Fix NVMe sanitize log return codes#1103
Merged
vojtechtrefny merged 1 commit intostoraged-project:masterfrom Apr 7, 2025
Merged
tests: Fix NVMe sanitize log return codes#1103vojtechtrefny merged 1 commit intostoraged-project:masterfrom
vojtechtrefny merged 1 commit intostoraged-project:masterfrom
Conversation
When calling nvme_get_log_sanitize() on a namespace device through io_uring codepath, return codes may differ slightly. This is perfectly fine, subject to the kernel implementation. In this case the errno 22 comes directly from io_uring_wait_cqe().
vojtechtrefny
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling nvme_get_log_sanitize() on a namespace device through io_uring codepath, return codes may differ slightly. This is perfectly fine, subject to the kernel implementation. In this case the errno 22 comes directly from io_uring_wait_cqe().
Fixes #1101